Conversation
Lotes
reviewed
Apr 14, 2026
Collaborator
Lotes
left a comment
Lotes
left a comment
There was a problem hiding this comment.
Nice idea with the range and index markers. Here are some questions, suggestions and ideas.
| } | ||
|
|
||
| func TestFindNamedNode(t *testing.T) { | ||
| f := fbtest.New(t, CreateServices()) |
Collaborator
There was a problem hiding this comment.
I like the grouping of lines.
For examples/ code: you could prepend "arrange", "act", "assert" as a little guidance for adopters.
But I do not insist on it, just a nice-to-have...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
Adds a basic testing infrastructure for languages. Informed by Langium and other projects. Currently, only supports testing of parsing, AST nodes, linking and diagnostics/validation. Other testing features (for example, LSP stuff) can come later.
Adds test files for the statemachine and grammar language.