Typescript 1.5 by basarat · Pull Request #179 · TypeStrong/atom-typescript

basarat · 2015-03-10T05:12:18Z

Things to do. An ever updating list:

Watch the filesGlob | files for changes. We only watch "changes" not "addition / deletion" for now.

…script into typescript-1.5

csnover · 2015-03-10T05:23:27Z

Yes, there is no version of TypeScript available anywhere that has the necessary patches to make ES6 import/export work with declarations (microsoft/TypeScript#2139), so what’s committed to my branch is a custom build with that patch applied. microsoft/TypeScript#2197 was also necessary in that build but has since been merged, so microsoft/TypeScript#2139 is the only one I’m waiting for until getting a new “official” build. Watch microsoft/TypeScript#2242 for updates!

basarat · 2015-03-10T05:24:38Z

^ the reply was for this diff from npm install

@csnover alright. So I will not run npm install ❤️ . I'll be doing new fixes in this branch just because I can't live without let anymore.

basarat · 2015-03-10T05:55:51Z

@csnover I suspect the reference bugs you are getting a specific to 1.5. Cannot do build ctrl+shift+b anymore. Fails with :

basarat · 2015-03-10T06:06:33Z

We are not doing fs checks for references. Only doing it for imports. I'll fix it tomorrow. Off for now.

…an extension closes #171

basarat · 2015-03-10T08:23:51Z

@csnover @park9140 I am feeling that having stuff that is not referenced from files in tsconfig.json is always going to result in tricky error cases : #180 and #45

I don't see a graceful way of handling this. Any ideas?

…ry tree

…ere was no tsconfig found closes #180

basarat · 2015-03-10T08:54:00Z

@csnover sorry #180 was fixable ❤️

Still don't have an answer for what to do with #45 though.

basarat · 2015-03-10T10:17:55Z

UPDATE: bug has been fixed

~~A bug for me :~~
this should not happen.

park9140 · 2015-03-10T15:43:21Z

@basarat, I was planning on using https://www.npmjs.com/package/vinyl-fs in order to simplify this scenario. You can populate a vinyl stream with the glob patterns and it will keep itself updated when you use the watch methodology.

basarat · 2015-03-10T20:53:54Z

Having a quick look I think it's meaning of glob is different : order is significant. I am sure the gulp users are used to it but that is not what we promised with our filesGlob. Our is that it must match all patterns.

I am leaning towards https://www.npmjs.com/package/gaze simply watching our glob and only updating our text if the file isn't open in the editor (which the child can query)

closes #118

…vices and followed the tree from there. Updated our language service to use the new ScriptInfo class. closes #176

… Will resume from home.

…do `updateText` needlessly refs #176

basarat · 2015-03-11T11:10:29Z

I can definitely feel the speed up ❤️

I blame atom. Very very badly. refs #183 (comment)

chore(watch) don't watch project file path for in memory projects

…endings. Found an alternative. Checked that it doesn't impact performance.

basarat · 2015-03-13T03:10:54Z

@csnover is it okay if I merge and publish this a new major version?

There are lot of good performance fixes here that I'd like to get in the hands of everyone. Its been working like a charm for me.

csnover · 2015-03-13T03:14:13Z

TS team was hoping to have microsoft/TypeScript#2139 landed by end of the week so can we maybe wait until Monday to see if that happens? Otherwise I don’t think I have any major objections.

basarat · 2015-03-13T03:21:12Z

Otherwise I don’t think I have any major objections.

Thanks I'll wait till monday ❤️

…s just as fast as emit success closes #184

…nside `getOrCreateProjectFile`

…so you can undo the entire file with one undo closes #157

closes #160

…tside of the atom view refs #177

…e assume col:1 (its one based)

…t-buffer reason: just as reliable as atom itself. No more, no less ❤️

closes #187

basarat · 2015-03-17T01:27:09Z

I've been using this over the weekend as well as on Monday. Its much better than what we have on master so publishing as a major version.

Typescript 1.5

basarat · 2015-03-17T01:30:45Z

I have merged into master. That's a good thing as I can ask people to just use master for the latest fixes. However I'm not going to publish till we have a valid package.json.

csnover and others added 3 commits March 8, 2015 15:41

Update to use TS1.5 services

36627e2

Correctly flatten diagnostic messages

8e25aea

Merge branch 'typescript-1.5' of https://github.com/csnover/atom-type…

5613dfb

…script into typescript-1.5

basarat mentioned this pull request Mar 10, 2015

Update to use TS1.5 services #150

Closed

basarat added 2 commits March 10, 2015 19:01

chore(queryParent) use let for the things that were annoying me

58e79ba

fix(tsconfig) expand properly for reference comments that don't have …

caa8e36

…an extension closes #171

basarat added 2 commits March 10, 2015 19:50

chore(tsconfig) minor refactor to add method to travel up the directo…

54150a3

…ry tree

chore(tsconfig) only create *its own project* for .d.ts files if th…

24494cd

…ere was no tsconfig found closes #180

basarat mentioned this pull request Mar 10, 2015

typescript playground microsoft/TypeScript#2246

Closed

This was referenced Mar 10, 2015

Emit detect broken #182

Closed

Struggling to get an emit failure with 1.5 microsoft/TypeScript#2290

Closed

basarat added 4 commits March 11, 2015 11:00

fix(emit) the rules for emit and success detection have changed

02622f9

chore(typescript) 1.5 doesn't need this fix

9c22d98

closes #118

feat(languageServiceHost) brought in ScriptInfo class from editor ser…

bdaff32

…vices and followed the tree from there. Updated our language service to use the new ScriptInfo class. closes #176

chore(fasterchangeobserver) work in progress. I need to go somewhere.…

64e838c

… Will resume from home.

basarat mentioned this pull request Mar 11, 2015

TSServer : make the ScriptInfo standalone microsoft/TypeScript#2297

Closed

basarat added 2 commits March 11, 2015 20:44

chore(dist) cleanup bad js files. Sorry.

578cd79

feat(languageService) efficiently send changes to worker. No need to …

9baf7f1

…do `updateText` needlessly refs #176

basarat mentioned this pull request Mar 11, 2015

Performance Issues With Undo/Backspace - Freezing/Crashing #183

Closed

chore(consistentpath) consistent path more things

13c71e6

basarat added 6 commits March 12, 2015 18:33

chore(LSHost) keeping the old LSHost up to date with fixes

bdb23d7

fix(autocomplete) fix(snippets) toString was showing up as a snippet

85bec36

fix(LSHost) it no longer goes out of sync with what atom sees.

8fd3610

I blame atom. Very very badly. refs #183 (comment)

chore(tsconfig) minor refactoring for a new utility function

81d52f5

chore(lib.d.ts) lib.d.ts is its own project

67ad709

chore(watch) don't watch project file path for in memory projects

fix(newlines) the change diff is not always correct in terms of line …

a32ce03

…endings. Found an alternative. Checked that it doesn't impact performance.

basarat added 3 commits March 13, 2015 14:31

fix(notfication) fix(compile) make the compile failed but emit succes…

7d41322

…s just as fast as emit success closes #184

chore(tsconfig) move the project creation logic into one place, all i…

d24c28f

…nside `getOrCreateProjectFile`

feat(refactor) rename takes place with a transaction for each editor …

8317a15

…so you can undo the entire file with one undo closes #157

basarat mentioned this pull request Mar 13, 2015

Atom freezing for 10 minutes (while building type information?) #148

Closed

basarat added 11 commits March 13, 2015 15:13

chore(tsconfig) notify use when creating it on disk

daa81f0

closes #160

chore(npm) added chokidar for #177

76be64a

feat(tsconfig) watch the filesGlob || files for file modifications ou…

271abac

…tside of the atom view refs #177

chore(languageSeviceHost) keep the old one updated with fixes

d4c0603

chore(languageServiceHost) make it easy to swap the two hosts

e002418

chore(debug) nothing significant. Just the current debug setup

c0c5743

chore(LSHost) minor fix for when leaf is undefined for some reason. W…

31f2b0a

…e assume col:1 (its one based)

chore(LSHost) add a new language service host based on atom's own tex…

e36d620

…t-buffer reason: just as reliable as atom itself. No more, no less ❤️

fix(LSHost) fix the LS version going out of sync

85f85c2

chore(tsconfig) consistency for formatCodeOptions

4c2208a

feat(compileOnSave) is now a tsconfig option

5c6bb97

closes #187

basarat added a commit that referenced this pull request Mar 17, 2015

Merge pull request #179 from TypeStrong/typescript-1.5

4d3f427

Typescript 1.5

basarat merged commit 4d3f427 into master Mar 17, 2015

basarat deleted the typescript-1.5 branch March 17, 2015 01:27

TypeStrong locked and limited conversation to collaborators Jan 20, 2019

Conversation

basarat commented Mar 10, 2015

Uh oh!

csnover commented Mar 10, 2015

Uh oh!

basarat commented Mar 10, 2015

Uh oh!

basarat commented Mar 10, 2015

Uh oh!

basarat commented Mar 10, 2015

Uh oh!

basarat commented Mar 10, 2015

Uh oh!

basarat commented Mar 10, 2015

Uh oh!

basarat commented Mar 10, 2015

Uh oh!

park9140 commented Mar 10, 2015

Uh oh!

basarat commented Mar 10, 2015

Uh oh!

basarat commented Mar 11, 2015

Uh oh!

basarat commented Mar 13, 2015

Uh oh!

csnover commented Mar 13, 2015

Uh oh!

basarat commented Mar 13, 2015

Uh oh!

basarat commented Mar 17, 2015

Uh oh!

basarat commented Mar 17, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants