[pull] master from williamfiset:master#139
Merged
pull[bot] merged 5 commits intoUncodedtech:masterfrom Apr 3, 2026
Merged
Conversation
…#1314) * Refactor ChineseRemainderTheorem: reuse PrimeFactorization, add tests Remove duplicated primeFactorization, pollardRho, isPrime, and gcf methods in favor of the shared PrimeFactorization class. Simplify prime-power grouping loop and clean up Javadoc. Add 17 JUnit 5 tests covering eliminateCoefficient, crt, reduce, egcd, and full reduce+crt integration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Keep CRT self-contained: inline prime factorization with Miller-Rabin Restore primeFactorization, pollardRho, isPrime, and supporting methods as private methods within ChineseRemainderTheorem rather than delegating to PrimeFactorization. Uses the improved Miller-Rabin primality test and overflow-safe mulMod instead of the original trial-division isPrime. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Simplify class Javadoc: remove @link references Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Expand class Javadoc with detailed CRT explanation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove UNTESTED note from Chinese remainder theorem in README Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Replace fragile MAX/MIN overflow guards with overflow-safe mulMod via BigInteger, supporting the full long range. Simplify the bit-mask exponentiation loop to standard binary exponentiation. Remove inline main() test code and add 11 JUnit 5 tests including a randomized check against BigInteger.modPow. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rename for clarity, add input validation, clean up Javadoc, remove main() and inline test helper. Add 10 JUnit 5 tests including BigInteger reference validation and edge cases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )