Skip to content

Add REPORT.md analyzing upstream JSONassert issues for incorporation#88

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/create-report-on-issues
Draft

Add REPORT.md analyzing upstream JSONassert issues for incorporation#88
Copilot wants to merge 2 commits intomainfrom
copilot/create-report-on-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 28, 2026

Analyzed all 68 open issues and open PRs from skyscreamer/JSONassert to identify bugs, security issues, and fixes worth incorporating into JSONassertify.

Report structure

  • 20 issues analyzed — categorized by priority with affected code paths and fix recommendations
  • 6 already-addressed items — documents what JSONassertify's existing changes (org.json migration, Java 8 target, GitHub Actions) already resolve
  • Actionable summary — prioritized into high/medium/low buckets

High priority findings

  • Long comparison precision loss (#203) — DefaultComparator.areNotSameDoubles() converts longs to doubles, silently treating distinct values like 3965376318358833921 and 3965376318358833920 as equal
  • JSONParser rejects null, true, false (#205) — valid JSON primitives throw JSONException
  • Trailing wildcard broken in Customization (#204) — foo.* doesn't match foo.bar due to String.split() discarding trailing empty strings
  • JSONString comparison failures have no detail (#101) — result.fail("") omits expected/actual values; one-line fix

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: JaredHatfield <208119+JaredHatfield@users.noreply.github.com>
Copilot AI changed the title [WIP] Add REPORT.md for issue analysis and suggestions Add REPORT.md analyzing upstream JSONassert issues for incorporation Feb 28, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.51%. Comparing base (f67be44) to head (dd81d78).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #88   +/-   ##
=========================================
  Coverage     94.51%   94.51%           
  Complexity      301      301           
=========================================
  Files            15       15           
  Lines           602      602           
  Branches        109      109           
=========================================
  Hits            569      569           
  Misses           14       14           
  Partials         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants