Add REPORT.md analyzing upstream JSONassert issues for incorporation#88
Draft
Add REPORT.md analyzing upstream JSONassert issues for incorporation#88
Conversation
Co-authored-by: JaredHatfield <208119+JaredHatfield@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add REPORT.md for issue analysis and suggestions
Add REPORT.md analyzing upstream JSONassert issues for incorporation
Feb 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
=========================================
Coverage 94.51% 94.51%
Complexity 301 301
=========================================
Files 15 15
Lines 602 602
Branches 109 109
=========================================
Hits 569 569
Misses 14 14
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analyzed all 68 open issues and open PRs from skyscreamer/JSONassert to identify bugs, security issues, and fixes worth incorporating into JSONassertify.
Report structure
High priority findings
DefaultComparator.areNotSameDoubles()converts longs to doubles, silently treating distinct values like3965376318358833921and3965376318358833920as equalnull,true,false(#205) — valid JSON primitives throwJSONExceptionfoo.*doesn't matchfoo.bardue toString.split()discarding trailing empty stringsresult.fail("")omits expected/actual values; one-line fix✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.