Skip to content

Improve #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MineKing9534 merged 2 commits into from
Aug 10, 2024
Merged

Improve #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd371b2
Improve string representation
MineKing9534 Aug 10, 2024
f48b92d
Implement hashcode properly
MineKing9534 Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/main/java/de/mineking/javautils/ID.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public static ID decode(@NotNull byte[] data) {

@NotNull
public String asString() {
return toString().substring(2); //Remove 2 leading zeros
return toString(data).substring(2); //Remove 2 leading zeros
}

@NotNull
Expand All @@ -97,8 +97,13 @@ public boolean equals(Object obj) {
return obj instanceof ID i && Arrays.equals(data, i.data);
}

@Override
public int hashCode() {
return Arrays.hashCode(data);
}

@Override
public String toString() {
return toString(data);
return asString();
}
}