feat: Add versioned distributions, replace non-versioned Alpine and Debian with wsl --import#85
Conversation
|
Thanks for your effort, really appreciate it.
|
|
@Vampire Thanks for the review.
Tried implementing
Running the OOBE is the intended behavior.
Done. "Debian" still points to the old bullseye AppxBundle URL and emits a deprecation warning in refresh().
Done. "Alpine" is removed since the MS Store API is permanently broken and the last working version cannot be determined.
Debian-13 ships with
The wsl.conf test was rewritten to use
Done. Replaced
Done. Removed productId constructors, _downloadUrl nullable pattern, rg-adguard API calls, Ktor HTTP client, and echo debug endpoint.
Done. installerFile is now
Done. Added |
|
Wow, nice, thanks.
Don't you send me my own discussion? :-D Anyway, how about using
You also deprecated Debian-11, why? Debian-11 should then of course also be added to the tests.
But I agree that it is better to not do that for the new way but use Other apk based dists in the future could support
Why not? The "Alpine" version is "3.17" for which also a minirootfs tarball exists.
That was actually just the precondition to ensure what the action should do is not there yet.
Is ktor still used somewhere? If I start to annoy you, just tell me, then I also can do the polishings probably, after you did really great work so far, thanks again. :-) |
|
If the proper We can also support additional distributions as for example listed on https://github.com/microsoft/WSL/blob/master/distributions/DistributionInfo.json, but that should probably be done separately later. |
|
Oh, and the new dists are missing in the |
|
And the dists and doc update in the readme template |
|
@Vampire I think the 2nd review batch were all addressed now.
Oh, I overlooked it.
Fixed. "Debian-11" is now an independent, non-deprecated distribution (not an alias for "Debian").
Done. Introduced
Done. "Alpine" is restored as a deprecated distribution pointing to Alpine 3.17 (the last working MS Store version). Alpine-3.17, 3.18, and 3.19 are added alongside the existing 3.20–3.23.
Done. The wsl.conf tests now verify content via
Done. Removed Ktor dependencies and the KTOR-6158 workaround.
Good idea.
Done. All distributions (including deprecated ones) added to action-types.yml and readme/README_template.md. The wsl.conf documentation now mentions Debian-13 alongside Ubuntu-24.04 as distributions that ship with a default wsl.conf. |
Actually 365, they were run twice due to the
Yeah, unfortunately. Anyway, I took this also as an opportunity and did some maintenance.
Actually the Kotlin update was the main reason, because I wanted to have guarded when-clauses available to simplify the installer code. :-) I merged my changes on Maybe you want in turn now review my change? :-)
|
0785097 to
e7cc6c4
Compare
|
Thanks! |
|
Oh, I claimed them for me accidentally. |
|
Done |
Changes
wsl --from-file --no-launchwith fallback towsl --import, instead of the AppxBundle installer.This is a breaking change as distributions get major version bumps.
I think it is a good timing to bundle with #84 (Node.js major version bump).