Block Editor: Prevent Enter key from inserting paragraphs in contentOnly sections#76989
Open
Block Editor: Prevent Enter key from inserting paragraphs in contentOnly sections#76989
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
[Type] Bug
|
Size Change: +7 B (0%) Total Size: 7.73 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 98a026d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23885654997
|
ramonjd
force-pushed
the
fix/cover-enter-pattern-paragraph
branch
from
013b1ba to
c4c5d5c
Compare
talldan
reviewed
Apr 2, 2026
Comment on lines
+1772
to
+1781
| @@ -1773,6 +1773,12 @@ export const insertBeforeBlock = | |||
| return; | |||
| } | |||
|
|
|||
| // Don't insert into containers with 'disabled' editing mode, | |||
| // e.g. structural blocks inside contentOnly sections. | |||
| if ( select.getBlockEditingMode( rootClientId ) === 'disabled' ) { | |||
| return; | |||
| } | |||
|
|
|||
Contributor
There was a problem hiding this comment.
We should use canInsertBlockType rather than maintaining separate logic for whether a block can be inserted.
Member
Author
There was a problem hiding this comment.
That sounds completely reasonable. 😄
Would the logic in canInsertBlockType need to be updated?
I wonder if it's enough to add a blockEditingMode === 'disabled'?
if (
isWithinSection &&
( isParentSectionBlock || blockEditingMode === 'contentOnly' || blockEditingMode === 'disabled' ) &&
...
)I can test. Or we can close this PR if it's too complicated 😄
Member
Author
There was a problem hiding this comment.
Hmmm seems to work, and I can't repro the bug below any more.
Since we're still wrangling to and fro, I'll push that change so folks can test.
talldan
reviewed
Apr 2, 2026
ramonjd
force-pushed
the
fix/cover-enter-pattern-paragraph
branch
from
c4c5d5c to
3c41ed9
Compare
…nly sections When a block like Cover sits inside a nested container (e.g. Column) within a contentOnly pattern, pressing Enter inserts a paragraph that can't be removed. canInsertBlockType didn't consider containers with 'disabled' editing mode when applying content-only insertion rules, so the disabled Column fell through and the paragraph was allowed. Include 'disabled' in the content-only check in canInsertBlockType so these containers go through the same sibling paragraph logic.
ramonjd
force-pushed
the
fix/cover-enter-pattern-paragraph
branch
from
3c41ed9 to
98a026d
Compare
t-hamano
approved these changes
Apr 2, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR, this PR works well, and the changes make sense to me.
Can we update the following comments according to the updated if condition? I believe we need to explicitly state the reason for checking both contentOnly and disabled.
gutenberg/packages/block-editor/src/store/selectors.js
Lines 1750 to 1754 in 98a026d
gutenberg/packages/block-editor/src/store/selectors.js
Lines 1767 to 1768 in 98a026d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where pressing Enter on a non-text block (e.g. a Cover block) inside a contentOnly pattern inserts an empty paragraph that can't be removed.
See #73222 (comment)
Why?
When a block like Cover sits inside a nested container (Column) within a contentOnly pattern, pressing Enter inserts a paragraph via
insertAfterBlock. The paragraph gets created becausecanInsertBlockTypedidn't consider containers withdisabledediting mode when applying content-only insertion rules.The condition only matched
contentOnlyand section block parents, so thedisabledColumn fell through and the paragraph was allowed. ButcanRemoveBlockrespects the Column'sdisabledediting mode, so the paragraph gets stuck.How?
Include
blockEditingMode === 'disabled'in the content-only insertion check incanInsertBlockTypeso that disabled containers (like Column inside a contentOnly section) go through the same "has existing sibling paragraph" logic.Testing Instructions
Also verify normal editing still works:
Screenshots
How it worked before
572275680-578c1a42-b86e-4eef-83ca-8a6436d335b1.mp4
How it should work (this PR)
2026-04-02.15.08.15.mp4