feat(ui): add reusable accordion with smooth animation#3869
feat(ui): add reusable accordion with smooth animation#3869ajaysehwal wants to merge 7 commits intoZeusLN:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new, animated accordion UI component built with Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new reusable Accordion component with smooth animation and integrates it into ActivityFilter.tsx and DeveloperTools.tsx. The new component effectively replaces previous manual expansion/collapse logic, simplifying the UI code in consuming components. However, the Accordion component's default styling is quite opinionated, leading to extensive style overrides in its usage, which could be improved for better reusability and maintainability. Additionally, a minor detail in the animation logic could be made more robust.
8cd1b45 to
2e9c698
Compare
…apply across ActivityFilter/DeveloperTools
2e9c698 to
8e39ca7
Compare
8e39ca7 to
df4d94e
Compare
Description
Please enter a description and screenshots, if appropriate, of the work covered in this PR
Reference from: https://docs.swmansion.com/react-native-reanimated/examples/accordion/
Summary
Introduces a reusable Accordion with animated expand/collapse, uses it across settings, tools, activity filters, and LSPS flows, and consolidates the old form-specific wrapper into a single component via
headerLayout="form". Trims unused props, adds layout shorthands, and fixes controlled accordion state in Activity Filter plus a small accessibility improvement.What changed
Accordion component (
components/Accordion.tsx)headerLayout="form": Form-style accordions (KeyValue title + caret, flat/embedded body styling)Standard (card) accordion
How to test
Screen.Recording.2026-04-06.at.12.16.59.PM.mov
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: