Updations in Wallet and Channel recovery section by kushagra0902 · Pull Request #3886 · ZeusLN/zeus

kushagra0902 · 2026-03-25T18:07:25Z

Description

Relates to issue: #3843

This PR have commits regarding the following issues and bugs:

Hex file format for SCB backup files is added. The implementation involves making a ScbUtils file in /Util that has the logic for parsing of scb strings instead of direct parsing using base64 types.
The Section for recovery didn't have a field for aezeed passphrase. The wallets made using them lnd wallets for example) thus cant be restored.
The changes in this PR do not change any logical/backend handling part of the code, and mainly handle file parsing types and user interface options.

The changes in this PR do not change any logical/backend handling part of the code, and mainly handle file parsing types and user interface options.

This pull request is categorized as a:

Checklist

[ x] I’ve run yarn run tsc and made sure my code compiles correctly
[ x] I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
[ x] I’ve run yarn run prettier and made sure my code is formatted correctly
[ x] I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

No, I’m a fool
[ x] Yes
N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

[ x] Android (Nothing Phone 2a, Android 15)
iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

Locales

[ x] I’ve added new locale text that requires translations
I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

Contributors will need to run yarn after this PR is merged in
3rd party dependencies have been modified:
- verify that package.json and yarn.lock have been properly updated
- verify that dependencies are installed for both iOS and Android platforms

Other:

Changes were made that require an update to the README
Changes were made that require an update to onboarding

]

gemini-code-assist · 2026-03-25T18:08:04Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the wallet and channel recovery experience by expanding the supported formats for Static Channel Backups (SCB) to include hex, in addition to Base64. It centralizes SCB parsing logic into a new utility, making the process more robust. Furthermore, the user interface for both SCB input and wallet recovery has been enhanced with a much-needed submit button and a new field for aezeed passphrases, addressing critical usability gaps without altering core backend logic.

Highlights

SCB Backup File Format Support: Introduced support for hex file format for SCB (Static Channel Backup) files, alongside the existing Base64 format, enhancing flexibility in channel recovery.
Dedicated SCB Parsing Utility: A new utility file, ScbUtils, was created to centralize the logic for parsing SCB strings, allowing for intelligent decoding of both Base64 and hex inputs.
Improved SCB Input UI: The UI for SCB input in the channel recovery section was updated to include a dedicated submit button, resolving an issue where users could not easily utilize channel backups.
Aezeed Passphrase for Wallet Recovery: Added an input field for the aezeed passphrase in the wallet recovery section, enabling the restoration of wallets created with aezeed passphrases (e.g., lnd wallets).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request significantly enhances the application's channel backup and wallet recovery functionalities. It introduces a new utility function, scbStringToBytes, which intelligently parses Static Channel Backup (SCB) data provided in either Base64 or hex format. This new utility is integrated into the restoreChannelBackups, verifyChanBackup, and initWallet functions, and the user interface and localization files have been updated to reflect this dual format support. Furthermore, the PR adds the capability to specify an aezeed passphrase during wallet recovery, complete with new UI elements. The review comments suggest renaming several parameters and state properties from channelBackupsBase64 to channelBackupsString for better clarity and consistency with the new hex support, and also recommend adding a missing newline at the end of the locales/en.json file.

gemini-code-assist · 2026-03-25T18:11:03Z

lndmobile/channel.ts

        method: 'RestoreChannelBackups',
        options: {
-            multi_chan_backup: Base64Utils.base64ToBytes(channels_backup_base64)
+            multi_chan_backup: scbStringToBytes(channels_backup_base64)


The parameter channels_backup_base64 used here is now misleading as it can also be a hex string. For consistency with the changes in lndmobile/wallet.ts (initWallet function), please consider renaming the parameter in the function signature to channelsBackupString.

gemini-code-assist · 2026-03-25T18:11:03Z

lndmobile/channel.ts

-                multi_chan_backup: Base64Utils.base64ToBytes(
-                    channels_backup_base64
-                )
+                multi_chan_backup: scbStringToBytes(channels_backup_base64)


Similar to my other comment, the parameter channels_backup_base64 is misleading now that it supports hex strings. Please consider renaming it to channelsBackupString for clarity and consistency.

gemini-code-assist · 2026-03-25T18:11:03Z

locales/en.json

    "androidNotification.nwcRunningBackground": "Nostr Wallet Connect is running in the background",
    "androidNotification.nwcShutdown": "Stop Service"
-}
+}


It's a common convention to have a single newline at the end of a file. This file is missing one. Please add a newline at the end for consistency with other files in the project and to prevent issues with some development tools.

Suggested change

}

}

gemini-code-assist · 2026-03-25T18:11:04Z

views/Settings/SeedRecovery.tsx

+                                        marginHorizontal: 20,
+                                        marginTop: 10
+                                    }}
+                                    disabled={!channelBackupsBase64}


The state property channelBackupsBase64 is now misleading as it can hold a hex string. For consistency with changes in lndmobile/wallet.ts, consider renaming it to channelBackupsString throughout this component.

…ings for channel recovery

…s field if the wallet was originally generated using a passphrase, without that it cannot be recovered.

gemini-code-assist bot reviewed Mar 25, 2026

View reviewed changes

kushagra0902 mentioned this pull request Mar 25, 2026

Updations in Wallet and Channel recovery section #3881

Closed

17 tasks

kushagra0902 force-pushed the recoveryFixes branch from f1a74be to 23e9659 Compare March 26, 2026 19:37

kaloudis force-pushed the master branch from f260099 to b544cc6 Compare March 26, 2026 23:52

kushagra0902 added 2 commits March 29, 2026 20:40

feat: Embedded node: added hex data format support for SCB backup str…

1c89c13

…ings for channel recovery

fix: added aezeed passphrase field for the recovery page. Without thi…

310ce71

…s field if the wallet was originally generated using a passphrase, without that it cannot be recovered.

kushagra0902 force-pushed the recoveryFixes branch from 23e9659 to 310ce71 Compare March 29, 2026 15:15

myxmaster mentioned this pull request Mar 30, 2026

Added a submit button for SCB backup screen #3898

Open

21 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updations in Wallet and Channel recovery section#3886

Updations in Wallet and Channel recovery section#3886
kushagra0902 wants to merge 2 commits intoZeusLN:masterfrom
kushagra0902:recoveryFixes

kushagra0902 commented Mar 25, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Mar 25, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Mar 25, 2026

Uh oh!

gemini-code-assist bot Mar 25, 2026

Uh oh!

gemini-code-assist bot Mar 25, 2026

Uh oh!

gemini-code-assist bot Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

kushagra0902 commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Testing

Locales

Third Party Dependencies and Packages

Other:

Uh oh!

gemini-code-assist bot commented Mar 25, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kushagra0902 commented Mar 25, 2026 •

edited

Loading