add validation for page_no#610
Closed
ziadhany wants to merge 2 commits intoaboutcode-org:mainfrom
ziadhany:view_fix
Closed
add validation for page_no#610ziadhany wants to merge 2 commits intoaboutcode-org:mainfrom ziadhany:view_fix
ziadhany wants to merge 2 commits intoaboutcode-org:mainfrom
ziadhany:view_fix
Conversation
pombredanne
requested changes
Feb 5, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! well spotted!
Do you mind to add a small unit test for this?
Member
|
And you also want to amend your commit to add your DCO signoff. |
Collaborator
Author
|
I couldn't find any previous test for view so a I create |
Signed-off-by: Ziad <ziadhany2016@gmail.com>
Signed-off-by: Ziad <ziadhany2016@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invalid literal for int() with base 10. at packages/search?type=deb&name=&page=/
So I add the correct validation to it.