Merged
Conversation
Contributor
|
@ziadhany please rebase your branch and add tests for oss-fuzz |
Collaborator
Author
I think we need to add Git Version/Version range aboutcode-org/univers#85 before merge this . |
Contributor
|
@ziadhany does this importer only give |
Collaborator
Author
Most of the data uses the git version, and there are rare cases that use both versions like this : https://github.com/google/oss-fuzz-vulns/search?p=1&q=fixed |
Contributor
|
@ziadhany let's ingest the data where we can get versions that are parsable by univers for now and add a follow up issue to ingest git versions from OSS-Fuzz. |
Contributor
|
@ziadhany please run the importer and improver on this and provide the logs for same. |
Collaborator
Author
A lot of logs like this and the importer add just 2617 row in vulnerabilities_advisory table . And the improve logs : |
Contributor
|
@ziadhany please add tests |
ziadhany
force-pushed
the
oss-fuzz
branch
2 times, most recently
from
ce96986 to
1f75c02
Compare
Collaborator
Author
|
@TG1999 |
pombredanne
reviewed
Sep 7, 2023
| @@ -0,0 +1,20 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
Please rename these expected files to use the same base name as a the test data file with an -expected.json suffix. Here do not use oss-fuzz-expected1.json. Instead use oss-fuzz-data1.yaml-expected.json .... ths way the test data file and the expected results show up side by side.
pombredanne
approved these changes
Sep 7, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
LGTM with a tiny nit for the test results expected file names
Contributor
|
@ziadhany thanks++ this looks good and we can merge it, please just resolve the merge conflicts. |
Add OSSFuzzImprover to IMPROVERS_REGISTRY Fix oss-fuzz test ( add weakness in expected test file ) Add oss-fuzz tests Import data from oss_fuzz using osv format Resolve merge conflicts Signed-off-by: ziadhany <ziadhany2016@gmail.com>
Collaborator
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using osv format #780 but we need to add support for oss-fuzz version , version range in univers and edit
get_fixed_version