This repository was archived by the owner on Mar 25, 2026. It is now read-only.
Conversation
mdonaka
commented
Apr 24, 2023
Author
mdonaka
left a comment
mdonaka
left a comment
There was a problem hiding this comment.
memo
job/table_data/ to value_table/
Author
|
@watason |
watason
approved these changes
Apr 24, 2023
Contributor
watason
left a comment
watason
left a comment
There was a problem hiding this comment.
PR is OK.
just occuread to me.
i think dbclient should not to be a singleton.
it is not advantage to making singlton.
eather is fine,though.
mdonaka
force-pushed
the
feature/nakata/clean_dbclient
branch
from
086b32c to
61133ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clean dbclient
Purpose
refactoring
Contents
value_tableandjoin_tabletojob/Testing Methods Performed