Skip to content
This repository was archived by the owner on Mar 25, 2026. It is now read-only.

Remove vjoin#229

Merged
mdonaka merged 12 commits intomainfrom
feature/nakata/remove_vjoin
Jun 7, 2023
Merged

Remove vjoin#229
mdonaka merged 12 commits intomainfrom
feature/nakata/remove_vjoin

Conversation

@mdonaka
Copy link
Copy Markdown

@mdonaka mdonaka commented Jun 6, 2023 •
edited
Loading

Summary

Remove vjoin

Purpose

To clarify the libclient interface

Contents

  • Remove vjoin
  • Fix various tests using execute request

example

# before
qmpc.get_join_table(([data_id1, data_id2], [2]))
# after
qmpc.get_join_table([data_id1, data_id2])

Testing Methods Performed

  • medium test
  • CI

@mdonaka mdonaka marked this pull request as ready for review June 6, 2023 11:33
@mdonaka
Copy link
Copy Markdown
Author

mdonaka commented Jun 7, 2023

@KotaTakahashi9320
I have modified the README.
Since there was no information on usage in libclient-py/README.md, I added it in libclient-py/quikcmpc/README.md.
fa0cb59

@KotaTakahashi9320
Copy link
Copy Markdown
Collaborator

KotaTakahashi9320 commented Jun 7, 2023

@mdonaka
Thanks for the change!
What do you think it would be better to clearly state that it is an option?

@mdonaka
Copy link
Copy Markdown
Author

mdonaka commented Jun 7, 2023

@KotaTakahashi9320
I added! 35d4eba

KotaTakahashi9320
KotaTakahashi9320 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@KotaTakahashi9320 KotaTakahashi9320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdonaka mdonaka merged commit 711a42e into main Jun 7, 2023
@mdonaka mdonaka deleted the feature/nakata/remove_vjoin branch June 7, 2023 06:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@KotaTakahashi9320 KotaTakahashi9320 KotaTakahashi9320 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdonaka @KotaTakahashi9320