This repository was archived by the owner on Mar 25, 2026. It is now read-only.
requestID is added to the communication from CC to BTS#249
Merged
Conversation
sakamoto-souta
changed the title
mdonaka
reviewed
Jul 5, 2023
mdonaka
left a comment
mdonaka
left a comment
There was a problem hiding this comment.
@sakamoto-souta
Thanks for the PR! I commented on two points．
Also, please rebase.
sakamoto-souta
force-pushed
the
feature/sakamoto/refactoring_ctob
branch
from
0ef5a9a to
5699988
Compare
mdonaka
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestID is added to the communication from CC to BTS
Purpose
In order to make sure that BTS always returns the same Triples in CC's retry
Contents
When CC requests Triples to BTS, CC also sends requestID.
BTS returns same Triples if requests have same requestID.
Testing Methods Performed
CI
Check that no error is generated by intentionally causing a retry.