Skip to content
This repository was archived by the owner on Mar 25, 2026. It is now read-only.

Clean libc to MC protobuf#250

Merged
mdonaka merged 20 commits intomainfrom
feature/nakata/split_get_computation
Jul 10, 2023
Merged

Clean libc to MC protobuf#250
mdonaka merged 20 commits intomainfrom
feature/nakata/split_get_computation

Conversation

@mdonaka
Copy link
Copy Markdown

@mdonaka mdonaka commented Jul 4, 2023 •
edited
Loading

Summary

Clean libc to MC protobuf

Purpose

libclient-py specification changes

Contents

  • Remove getDataList request
  • Divide getComputationResult into getComputationResult, getComputationStatus and GetJobErrorInfo

Testing Methods Performed

  • medium test
  • CI

@mdonaka mdonaka force-pushed the feature/nakata/split_get_computation branch from 071df6c to 6cdc0d7 Compare July 5, 2023 09:48
@mdonaka mdonaka marked this pull request as ready for review July 6, 2023 04:07
@mdonaka mdonaka force-pushed the feature/nakata/split_get_computation branch from 108876d to 4b6b7ee Compare July 10, 2023 03:00
KotaTakahashi9320
KotaTakahashi9320 suggested changes Jul 10, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@KotaTakahashi9320 KotaTakahashi9320 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdonaka
Thank you for your contribution!
Please check comment.

Comment thread demo/client_demo/integration_demo/execute_demo.py Outdated
Comment thread proto/libc_to_manage_container/libc_to_manage.proto Outdated
Comment thread scripts/libclient/src/tests/test_job_error_info.py Outdated
mdonaka and others added 4 commits July 10, 2023 15:20
@mdonaka @KotaTakahashi9320
Update val name
fd0e50c 
Co-authored-by: Kota Takahashi <91713065+KotaTakahashi9320@users.noreply.github.com>
@mdonaka @KotaTakahashi9320
Remove Unnecessary space
f7590fb 
Co-authored-by: Kota Takahashi <91713065+KotaTakahashi9320@users.noreply.github.com>
@mdonaka @KotaTakahashi9320
Remove debug print
834754a 
Co-authored-by: Kota Takahashi <91713065+KotaTakahashi9320@users.noreply.github.com>
@mdonaka
Fix val name
30e101f
@mdonaka
Copy link
Copy Markdown
Author

mdonaka commented Jul 10, 2023

@KotaTakahashi9320
Thank you for review! I fix everything.

KotaTakahashi9320
KotaTakahashi9320 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@KotaTakahashi9320 KotaTakahashi9320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdonaka mdonaka merged commit 45ae8a4 into main Jul 10, 2023
@mdonaka mdonaka deleted the feature/nakata/split_get_computation branch July 10, 2023 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@KotaTakahashi9320 KotaTakahashi9320 KotaTakahashi9320 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdonaka @KotaTakahashi9320