Skip to content
This repository was archived by the owner on Mar 25, 2026. It is now read-only.

Fix to_float bug when read_csv#274

Merged
mdonaka merged 7 commits intomainfrom
feature/nakata/id_to_float
Oct 10, 2023
Merged

Fix to_float bug when read_csv#274
mdonaka merged 7 commits intomainfrom
feature/nakata/id_to_float

Conversation

@mdonaka
Copy link
Copy Markdown

@mdonaka mdonaka commented Sep 25, 2023

Summary

FIx bug

Purpose

Allow integer to be accepted as ID column.

Contents

  • Add to_float_for_matching
    • This will hash any value
  • Remove parse_csv
    • Because the specifications are different and it is not used

Testing Methods Performed

  • pytest
  • CI

ETC

From this PR, the ID column of dataframe (data obtained by read_csv) is required to be a numerical value.

@mdonaka mdonaka marked this pull request as ready for review September 25, 2023 10:09
@mdonaka mdonaka merged commit cbb4d47 into main Oct 10, 2023
@mdonaka mdonaka deleted the feature/nakata/id_to_float branch October 10, 2023 07:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants