One preference manager integration test is failing on Mac

[RaymondLim]

Test case "should find preferences in the project" always fails with "Error: Expected 4 to be 92."

[RaymondLim]

Bisect points to this commit e18ebfb.

[dangoor]

This fails for me on your view-state-migration branch, but not on master. I've run this test quite a bit recently without issue.

[RaymondLim]

This actually fails in the master. I noticed it from Jenkins' email notification. And I don't think git bisect lies to me since my branch is not yet merged to the master. Note that this is mac only issue though.

[dangoor]

Oh, I see. It looks like a difference in timing between the Jenkins machine and mine. The check that it was doing to see that project prefs were loaded would always pass. I just committed a fix in ceea715 that makes sure the correct project prefs are loaded before moving on. We'll see after the jenkins run if that fixes the issue.

Thanks for noticing this!

[dangoor]

The fix I pushed earlier makes the test pass sometimes, and PR #6925 will likely make the test pass. If it doesn't #6910 will be the real fix for this. I don't want to do #6910 yet, because it may be impacted by #6719

[dangoor]

I pushed a minor change in 4eb4797 that should make the test resilient to timing differences.

[dangoor]

Still failing, so it's apparently not a timing issue.

[dangoor]

I managed to get this failing sporadically on my machine, and then the problem became obvious to me once i saw which file was open in the test window. 57deb81 should fix this for real.

FBNC to @RaymondLim (and the build server, which I'll keep an eye on 😁)

[RaymondLim]

Yes, confirmed that 57deb81 fixed the failing test.