Bottom border of Quick Open text field has wrong color

[peterflynn]

1. Type a non-existent filename into Quick Open so there are no results
2. Type a Goto Line query (something starting with ":")

Results:
1 - Quick Open field has a red border, except bottom border is gray
2 - Quick Open field has a blue border, except bottom border is gray

This broke due to PR #5921, so assigning to @larz0

The problem is that the "smart autocomplete" dropdown is still visible, just empty, so it collapses to just a px or so tall. That will be fixed by PR #7227, but I don't think that's going to fit in the current sprint so in the meantime our CSS will have to work around the issue.

[larz0]

This is a duplicate of #5029. I was going to fix it by removing the border completely but it doesn't look as good without the border.

[peterflynn]

@larz0 It's not a dupe in the sense that the behavior is noticeably worse on master now. Before, you could see the focus-ring color on all 4 sides, but if you resize the window you'll see a gray line break off from that. Now, you only see 3 sides of the colored border and it's visible 100% of the time to all users (no resizing required).

This is because the recent CSS changes made the focus rectangle thinner, so it no longer sticks out past the gray rectangle. I think for Sprint 38 we should just revert that one CSS change, and when my new Quick Open widget lands (hopefully Sprint 39) then you can reinstate the thinner focus ring here.

[larz0]

I think they both look pretty weird with gray border. I'd like to remove the border completely for Sprint 38 because it's has less impact (that drop down border is only used for Quick Open).

[larz0]

@peterflynn pull request is up.

[larz0]

The fix is in master now, closing.