This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fixing update notification locale issue, update notification was shown in English for all locales#14995
Merged
narayani28 merged 2 commits intoadobe:masterfrom Feb 12, 2020
g-217:jha-g/fixing-update-notification-locale
Merged
Fixing update notification locale issue, update notification was shown in English for all locales#14995narayani28 merged 2 commits intoadobe:masterfrom g-217:jha-g/fixing-update-notification-locale
narayani28 merged 2 commits intoadobe:masterfrom
g-217:jha-g/fixing-update-notification-locale
Conversation
…n in English for all locales
shubhsnov
suggested changes
Dec 6, 2019
Contributor
Author
|
@niteskum @swmitra @narayani28 please review. |
Collaborator
|
👍 LGTM |
niteskum
pushed a commit
that referenced
this pull request
Mar 25, 2020
…-locale Fixing update notification locale issue, update notification was shown in English for all locales
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing pre-release specific code from release code, as it is causing update notification to be shown in English for all locales.
This will fix #14994