When Find has no results, turn search field bg color red#1914
When Find has no results, turn search field bg color red#1914
Conversation
than old behavior where selection disappears w/ no other feedback. Also fix indentation in search bar LESS code, and move one misplaced Dialog style to the right LESS file (with better docs).
There was a problem hiding this comment.
This is currently only used in a dialog, but it's not limited to dialogs.
There was a problem hiding this comment.
Only text used in a dialog will actually get turned into a clickable link though -- since the style implies actual functionality changes there, it seems fairly closely bound to Dialog for now.
ghost
assigned
There was a problem hiding this comment.
Usually when I see this pattern , the text is also changed to white.
There was a problem hiding this comment.
It seems mixed: Firefox uses white on red, but Chrome and IntelliJ keep the text black (albeit in IntelliJ at least the red is quite pale). You think it would look better if I make the background a bit paler?
There was a problem hiding this comment.
I just thought I'd mention it to make sure you considered it. It's ok as is and we can listen for feedback.
|
Done with initial review. This looks cool. Just a couple minor comments. |
|
Looks good. Merging. |
When Find has no results, turn search field bg color red
2 participants
When Find has no results, turn search field bg color red. Less ambiguous than old behavior where selection disappears w/ no other feedback.
Also fix indentation in search bar LESS code, and move one misplaced Dialog style to the right LESS file.