This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fixed: #1863 Selector width info is wrong when no space before '{'#3082
Merged
redmunds merged 5 commits intoadobe:masterfrom Mar 14, 2013
Merged
Fixed: #1863 Selector width info is wrong when no space before '{'#3082redmunds merged 5 commits intoadobe:masterfrom
redmunds merged 5 commits intoadobe:masterfrom
Conversation
ghost
assigned
Contributor
|
This looks good. Can you add some unit tests to the CSSUtils tests with rules as follows:
|
Contributor
|
Done with initial review. |
Contributor
Author
|
@redmunds i added the unit tests and also fixed a few more edge cases |
test/spec/CSSUtils-test.js
Outdated
Contributor
There was a problem hiding this comment.
Since you're using the same .css file for all tests in this section, and the file is not being edited, there's no need to run extractAllSelectors() (which is not cheap) before each test. The tests will run faster if this is done only once.
Contributor
|
Done with second review. |
Contributor
Author
|
@redmunds ready for final review |
Contributor
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 14, 2013
Fixed: #1863 Selector width info is wrong when no space before '{'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: #1863 and also fixed a few other cases where selection was incorrect