This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix #3100: New lines always create white spaces#3209
Merged
redmunds merged 2 commits intoadobe:masterfrom Mar 22, 2013
TomMalbran:tom/fix-issue-3100
Merged
Fix #3100: New lines always create white spaces#3209redmunds merged 2 commits intoadobe:masterfrom TomMalbran:tom/fix-issue-3100
redmunds merged 2 commits intoadobe:masterfrom
TomMalbran:tom/fix-issue-3100
Conversation
src/editor/Editor.js
Outdated
Contributor
There was a problem hiding this comment.
Line 1339 has 2 tab chars. Remove or convert to spaces.
Contributor
|
Done with initial code review. |
ghost
assigned
Contributor
Author
|
Fixed pushed. |
Contributor
|
This looks good. Thanks, @TomMalbran . Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 22, 2013
Fix #3100: New lines always create white spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #3100. The idea is that now changing Spaces and Tabs both also change the indent unit option of all the open editors, since Indent Unit is used for both and not just for Spaces.