This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Merged
Conversation
ghost
assigned
Contributor
|
Yes, for me this seems good (enough). The only thing that could be better is the margin-left when the first part of the dialog disappears, but I think this is ok. |
Contributor
Author
|
@SAplayer could you recheck. |
Contributor
|
Yes, now it seems really good (but I don't know if it works on low resolutions, too). |
Contributor
|
I tried it out and it seems to work great. We're at the end of Sprint 32, so I won't be merging this in until next week. |
Contributor
|
Looks good. Tested on Win7 and OSX 10.8. Merging. |
Closed
This was referenced Aug 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@redmunds
Finally found a general fix for the dialog positioning issues (#5296).
cc @njx