This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Standardize the format of nls files (de and root)#5505
Merged
jbalsas merged 1 commit intoadobe:masterfrom Oct 14, 2013
Merged
Conversation
Contributor
|
Hi! This PR aside, I built an extension some time ago to help comparing the nls files from within Brackets. It's available in the registry, and you can check it out at https://github.com/jbalsas/brackets-localization-workflow. It compares the strings on a translation with those on the root file and warns you of missing, unused or apparently untranslated strings. Just in case you want to check it out ;) |
Contributor
Author
|
@jbalsas Thanks for the tip, I will take a look at it ;) And yes, it sounds really interesting to me as I'm currently best on editing localization files. |
ghost
assigned
Contributor
|
@jbalsas Would you mind going ahead and review this? |
Contributor
|
I've checked and german translation seemed to be the only one with extra line breaks. Looks good. Merging |
jbalsas
added a commit
that referenced
this pull request
Oct 14, 2013
Standardize the format of nls files (de and root)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little fix, with it we can use the lines count to roughly compare two nls files. Maybe we can do this for other languages, too.