Exclude file ext from initial selection when renaming a file.

[Robo210]

This change performs the rename as usual through JSTree, then
grabs the DOM node and adjusts the selection on it after the fact.
This fixes issue #7019

[zaggino]

Initial review done, works & looks fine.

[ingorichter]

@zaggino could you please finish this review and when you are done please merge. Thanks.

[peterflynn]

Should it be first index of "." instead? If I have e.g. "foo.css.erb" I'd just want to rename the "foo" part.

[zaggino]

When renaming files like less-1.4.2.min.js, usually only the last part is considered an extension.

[zaggino]

Ignore comment, good to merge. My blind self.

[zaggino]

@peterflynn - this could be done as a separate PR because it's a bit more complicated. Should we search the languages.json for known extensions that have . in them and use this for selecting?

[peterflynn]

Seems plausible, but I don't know if we have to get that fancy. Your argument above sounded reasonable enough to me -- let's wait & see if we get any feedback about it?

[Denisov21]

Hi,
I think it works well now. I share the opinion on "foo.css.erb" is only the extension *.erb. Thanks for the work guys!

[zaggino]

I don't know - I realized I like the fancy idea and also implementation was just a few lines so I made up a PR and I'll leave to others to merge or not to merge :)

[zaggino]

Btw @peterflynn we do not longer use doublequotes " for strings?
I don't see any "quotmark": "double" in https://github.com/adobe/brackets/blob/master/.jshintrc but I remember I was told to do that before.

[peterflynn]

@zaggino Ah, yes -- all JS code should use double-quoted strings (per style guide). So the string in the lastIndexOf() call here should be fixed. Could you roll that into your PR?

[zaggino]

Already did that for PR. Also tried using "quotmark": "double" in JSHint and it blew out a lof of ' usage, especially in test/ but also 20 or so in src/

[peterflynn]

Seems worth fixing the ones in src at least, though not high priority...