This repository was archived by the owner on Sep 6, 2021. It is now read-only.
[BezierEditor] Fix fadeout issue#7248
Merged
redmunds merged 1 commit intoadobe:masterfrom Mar 21, 2014
Merged
Conversation
Contributor
|
@SAplayer I could review pull requests faster if the branch names weren't so long :) |
Contributor
Author
|
@redmunds I'll try to use a shorter one next time ;) |
|
@redmunds Try https://github.com/defunkt/hub - then you can do things like |
Member
|
I always just copy-paste the branch name from the top of the PR into the terminal, personally :-) Or you can click the "command line" link at bottom (next to the merge button) and copy the full command line to the clipboard in 1 click... |
Contributor
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 21, 2014
…fadeout-fix [BezierEditor] Fix fadeout issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue, introduced by #7235:
cubic-bezier(1.000001, 0, 0, 0)Result: The hint is immediately hidden
Expected: The fadeout should continue
This PR makes the code a bit cleaner (using
editor.hintobject for everything that has to do with the hint) and uses.hide(), suggested by @zaggino.