Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Translation updates for zh-cn.#7259

Merged
RaymondLim merged 6 commits intoadobe:masterfrom
peterfyj:master
Mar 24, 2014
Merged

Translation updates for zh-cn.#7259
RaymondLim merged 6 commits intoadobe:masterfrom
peterfyj:master

Conversation

@peterfyj
Copy link
Copy Markdown
Contributor

This is a translation update for Simplified Chinese.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Finder has to be localized. I switched my mac to Simplified Chinese and Finder in the menu bar is not localized. So we should just keep it as the original App name.

@RaymondLim
Copy link
Copy Markdown
Contributor

@peterfyj Can you also translate "Project Settings for: {0}" on line 364?

1. No translation for 'Finder'.
2. Translate also 'Project Setting for...'.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you retranslate this one? Originally it was Reload {APP_NAME}, but recently it was changed to Reload With Extensions.

@RaymondLim
Copy link
Copy Markdown
Contributor

@peterfyj Thanks for correcting those incorrect translations. But I have some more for you. At sometimes Live Development was changed to Live Preview. So some strings in this file are still translated as Live Development. Can you update a comment and some strings on line 80, 88, 91 and 94?

And also "EXTENSION_UPDATE_INSTALLED" has been changed and Chinese translation needs to be updated on line 442.

When you're done with all translation, can you also add the following comment line at the end of this file? You may need to get the correct SHA of the English strings.js file. I'm just showing the current SHA as an example here. You can copy SHA from this history page https://github.com/adobe/brackets/commits/master/src/nls/root/strings.js by hovering on the one you used for this pull request and click on Copy SHA button.

/* Last translated for c0eb5be239f16c83e950665c7d63d775ba952855 */

@marcelgerber
Copy link
Copy Markdown
Contributor

@RaymondLim Just because I'm usually translating into german - should we add this comment to every translation we have done, even if they are translated regularly?
It would at least make sense.

@RaymondLim
Copy link
Copy Markdown
Contributor

@SAplayer Yes, that's the idea. I'll be updating Localization Readme with this requirement and announcing this change in the google group. You can go ahead and add this for German strings.js. Thanks.

@marcelgerber
Copy link
Copy Markdown
Contributor

Will do it with the next PR (on release branch - shortly before the release of Sprint 38).

1. Replace `Live Development` with `Live Preview`.
2. Update translation for `EXTENSION_UPDATE_INSTALLED`.
3. Add the 'Last translated for ...' line.
@peterfyj
Copy link
Copy Markdown
Contributor Author

@RaymondLim I'am not quite sure about line 91 & 94 you mentioned, since they were translated as Live Preview.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why some junk characters are showing up here. I copied the entire page as utf-8 to my local file and everything shows up correctly. @peterfyj Can you confirm that you see the translation correctly in your local version?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLim The junk characters only appear on the browser diff, not even in the quote of your comment. It's weird and I'm digging into it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it correctly in the quote of my comment. So I believe it's ok.

@RaymondLim
Copy link
Copy Markdown
Contributor

@peterfyj I think your changes for line 91 and 94 are fine.

@RaymondLim
Copy link
Copy Markdown
Contributor

Looks good now. Merging.

RaymondLim added a commit that referenced this pull request Mar 24, 2014
Translation updates for zh-cn.
@RaymondLim RaymondLim merged commit 0723efe into adobe:master Mar 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants