This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Define English (UK) language to use for differences between US and UK#7333
Merged
ingorichter merged 1 commit intomasterfrom Apr 1, 2014
Merged
Define English (UK) language to use for differences between US and UK#7333ingorichter merged 1 commit intomasterfrom
ingorichter merged 1 commit intomasterfrom
Conversation
Contributor
|
@zaggino I'm done with my review. Once we resolved the CLA check issue, I'm going to merge this PR. Thanks. |
Member
|
@ingorichter I think we can merge even though the Travis build is failing... since we know @zaggino specifically has already signed it. |
ingorichter
added a commit
that referenced
this pull request
Apr 1, 2014
Define English (UK) language to use for differences between US and UK
Contributor
|
Thanks @zaggino! Merged! |
|
In strings.js it should be en-gb not en-UK. Also the default en needs changing to en-us. |
Contributor
zaggino
added a commit
that referenced
this pull request
Apr 22, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to use different date formats for US & UK and this'd enable me to do so.
Discussed also here:
https://groups.google.com/forum/#!topic/brackets-dev/aeilzKeMeCw
P.S.: I'm not sure if the current language should be renamed into
English (US)ping @SAplayer