Skip to content

chore: remove dead packages/cli/script/publish.ts (#54)#56

Merged
byapparov merged 1 commit intomainfrom
feature/issue-54-remove-dead-publish-script
Apr 12, 2026
Merged

chore: remove dead packages/cli/script/publish.ts (#54)#56
byapparov merged 1 commit intomainfrom
feature/issue-54-remove-dead-publish-script

Conversation

@byapparov
Copy link
Copy Markdown
Contributor

Summary

  • Deletes packages/cli/script/publish.ts, which is unreferenced dead code that would publish a parallel @aictrl/cli-ai package if anyone ever ran it
  • The real publish pipeline is .github/workflows/publish.yml; this script is not invoked from any workflow or npm script

Verification

  • Grep for publish.ts/script/publish across .github/, all package.json, packages/, infra/, nix/ returns zero non-cosmetic hits
  • bun turbo typecheck passes after deletion

Closes #54

🤖 Generated with Claude Code

This script was a parallel publish orchestration that wrote the package
under name `@aictrl/cli-ai` (note the -ai suffix) and was never invoked
by any workflow or npm script. The real publish pipeline lives in
.github/workflows/publish.yml. Removing it eliminates a foot-gun where
running it accidentally would publish a parallel @aictrl/cli-ai package.

Closes #54

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Review: chore: remove dead packages/cli/script/publish.ts

Verdict: LGTM — safe to merge. The deletion is correct and well-justified.

Verification

  • The CI workflow (.github/workflows/publish.yml) handles all publishing directly — it builds with bun turbo build, then publishes each package in dedicated steps. It does not invoke packages/cli/script/publish.ts or any script in packages/cli/script/.
  • The workflow comment at line ~100 explicitly calls this "the legacy script/publish.ts" and already includes a regex guard (/^@aictrl\/cli-(linux|darwin|windows)(-[a-z0-9]+)+$/) to prevent the @aictrl/cli-ai wrapper (which this deleted script produced) from leaking into optionalDependencies. This confirms the file was already considered obsolete.
  • No package.json scripts, Makefiles, or CI configs reference this file.

Follow-up suggestion (not a blocker)

The root-level script/publish.ts still contains a dynamic import of ../packages/aictrl/script/publish.ts, but the packages/aictrl/ directory does not exist in this repo (the CLI package lives at packages/cli/). This import would fail at runtime, meaning the root publish script is also dead code. Consider removing it (and the other orphaned imports it contains) in a follow-up PR.

Reviewed SHA: 6886fe7

@byapparov byapparov merged commit 5c3817a into main Apr 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead packages/cli/script/publish.ts (publishes as @aictrl/cli-ai, unused)

1 participant