Open
Conversation
re.fullmatch('^(?!win32)(?!cygwin)') will only match start of line followed by
not 'win32' and not 'cygwin' followed by nothing meaning an empty string.
This causes static to be skipped on platforms it was intended to be run on
such as linux.
Fix by changing the regular expression to '^(?!win32)(?!cygwin).*$' which will
full match start of line followed by not 'win32' and not 'cygwin' followed by
anything followed by end of line.# Please enter the commit message for your changes. Lines starting
Use defaults for AsyncReader Protocol pytype understands: - read(n: int = -1) - matches asyncio default (read all) - readuntil(separator: bytes = b'\n') - matches asyncio default
Adds assert isinstance(login_and_password, bytes) to narrow the _TriStateType Union before calling .split(). This fixes the pytype error 'No attribute split on _Missing'.
Author
|
mypy did not detect any of these errors. Would you prefer to suppress them in pytype rather than make code changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Are there changes in behavior for the user?
No.
Related issue number
Related #544.
Checklist
static{py36,py37,py38,py39}-{nocov,cov,diffcov}{py36,py37,py38,py39}-{nocov,cov,diffcov}, pypy3-{nocov,cov}, qa, docs{py36,pypy3}-{nocov,cov,diffcov}, qapy36-{nocov,cov,diffcov}, qa, docsNEWS.rstfile