Skip to content

Add Telecom Jetpack library snippets#876

Merged
kkuan2011 merged 5 commits intoandroid:mainfrom
natarajkr007:telecom
Apr 21, 2026
Merged

Add Telecom Jetpack library snippets#876
kkuan2011 merged 5 commits intoandroid:mainfrom
natarajkr007:telecom

Conversation

@natarajkr007
Copy link
Copy Markdown
Contributor

  • Add snippets for VoIP call log exclusion
  • Add snippets for handling VoIP callback intents
  • Add snippets for dialer callback initiation
  • Add sample dialer and VoIP app modules for Telecom
  • Add core-telecom dependency and necessary permissions configuration

* Add snippets for VoIP call log exclusion
* Add snippets for handling VoIP callback intents
* Add snippets for dialer callback initiation
* Add sample dialer and VoIP app modules for Telecom
* Add core-telecom dependency and necessary permissions configuration
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Apr 20, 2026

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new modules, :telecom:dialer and :telecom:voipapp, to demonstrate Jetpack Telecom features such as VoIP call log integration and callback handling. The review feedback identifies critical syntax errors in the Gradle configuration for compileSdk across both modules and the use of a non-standard API constant in a @RequiresApi annotation. Additionally, the reviewer pointed out several instances of unused variables and methods, as well as a logical inconsistency regarding the return type of a helper function in the VoIP application.

Comment thread telecom/dialer/build.gradle.kts
Comment thread telecom/voipapp/build.gradle.kts
Comment thread telecom/voipapp/src/main/java/com/example/voipapp/VoipCallbackActivity.kt Outdated
Comment thread telecom/dialer/src/main/java/com/example/dialer/MainActivity.kt Outdated
Copy link
Copy Markdown
Contributor

@kkuan2011 kkuan2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spotless check seems to be failing too, I'm not sure if this is because the change is coming from a forked version of the repo. I also saw it for the failed spotless check on this PR: #866

Comment thread settings.gradle.kts
Comment thread telecom/dialer/src/main/java/com/example/dialer/ui/theme/Type.kt Outdated
Comment thread telecom/dialer/src/main/java/com/example/dialer/ui/theme/Color.kt
Comment thread telecom/dialer/src/main/java/com/example/dialer/ui/theme/Color.kt
Comment thread telecom/dialer/src/main/java/com/example/dialer/MainActivity.kt Outdated
Comment thread telecom/dialer/src/main/java/com/example/dialer/MainActivity.kt
Comment thread telecom/dialer/src/main/res/values/strings.xml Outdated
Comment thread telecom/voipapp/src/main/java/com/example/voipapp/ui/main/MainViewModel.kt Outdated
Comment thread telecom/voipapp/src/main/java/com/example/voipapp/VoipCallbackActivity.kt Outdated
natarajkr and others added 3 commits April 21, 2026 15:29
* Add license headers to XML and Kotlin files in dialer and voipapp modules
* Apply minor code formatting and cleanup to Kotlin files
* Standardize XML declarations in resource files
* Migrate `VoipCallbackActivity` to Jetpack Compose
* Remove unused XML layouts, Fragments, and ViewModels from `voipapp`
* Add Compose dependencies and build features to `voipapp`
* Clean up unused variables and comments in `dialer` module
* Update `dialer` app name string to "Dialer"
* Update `RequiresApi` level to 37 in `VoipCallbackActivity`
@natarajkr007 natarajkr007 requested a review from kkuan2011 April 21, 2026 15:22
@kkuan2011 kkuan2011 merged commit 6f769f0 into android:main Apr 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants