Skip to content

fix(@angular/cli): fix broken img ref in ai-tutor#33052

Merged
dgp1130 merged 1 commit intoangular:mainfrom
devchas:ai-tutor-img-fix
Apr 27, 2026
Merged

fix(@angular/cli): fix broken img ref in ai-tutor#33052
dgp1130 merged 1 commit intoangular:mainfrom
devchas:ai-tutor-img-fix

Conversation

@devchas
Copy link
Copy Markdown
Contributor

@devchas devchas commented Apr 24, 2026

replacing the existing link with INSERT_IMAGE_URL makes the model insert a working link or the user can insert themselves

Fixes #32908

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 32908

What is the new behavior?

The model should insert a working link when populating the files or the user can update themselves

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

replacing the existing link with `INSERT_IMAGE_URL` makes
the model insert a working link or the user can insert themselves

Fixes angular#32908
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ai-tutor.md resource by replacing specific placeholder image URLs with a generic 'INSERT_IMAGE_URL' string. The review feedback suggests using functional placeholder URLs from a service like placehold.co instead of the generic string. This ensures that the AI tutor provides working image links in the generated code, preventing broken images in the user's application.

Comment thread packages/angular/cli/src/commands/mcp/resources/ai-tutor.md
Comment thread packages/angular/cli/src/commands/mcp/resources/ai-tutor.md
Comment thread packages/angular/cli/src/commands/mcp/resources/ai-tutor.md
Comment thread packages/angular/cli/src/commands/mcp/resources/ai-tutor.md
Comment thread packages/angular/cli/src/commands/mcp/resources/ai-tutor.md
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 27, 2026
@dgp1130 dgp1130 merged commit 0572df0 into angular:main Apr 27, 2026
38 checks passed
@dgp1130
Copy link
Copy Markdown
Collaborator

dgp1130 commented Apr 27, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/cli target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular AI Tutor: via.placeholder.com does no longer work

4 participants