refactor: move Karma migration utilities to the migrate-karma-to-vitest directory#33066
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Apr 28, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the remove-default-karma-config migration and its associated tests, while consolidating Karma configuration utilities. The review feedback highlights that several import paths in the migrate-karma-to-vitest migration were incorrectly updated to point to a parent directory instead of the local folder. Additionally, the generateDefaultKarmaConfig function should remain exported as it is still required by the unit tests.
…st directory The standalone migration is no longer used.
199b8ac to
b95c47e
Compare
clydin
approved these changes
Apr 28, 2026
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone migration is no longer used.