Skip to content

refactor: move Karma migration utilities to the migrate-karma-to-vitest directory#33066

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:remove-karma-migration
Apr 28, 2026
Merged

refactor: move Karma migration utilities to the migrate-karma-to-vitest directory#33066
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:remove-karma-migration

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

The standalone migration is no longer used.

@alan-agius4 alan-agius4 requested a review from clydin April 28, 2026 08:39
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Apr 28, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the remove-default-karma-config migration and its associated tests, while consolidating Karma configuration utilities. The review feedback highlights that several import paths in the migrate-karma-to-vitest migration were incorrectly updated to point to a parent directory instead of the local folder. Additionally, the generateDefaultKarmaConfig function should remain exported as it is still required by the unit tests.

…st directory

The standalone migration is no longer used.
@alan-agius4 alan-agius4 force-pushed the remove-karma-migration branch from 199b8ac to b95c47e Compare April 28, 2026 08:45
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 28, 2026
@alan-agius4 alan-agius4 merged commit 7c1eede into angular:main Apr 28, 2026
59 of 63 checks passed
@alan-agius4
Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the remove-karma-migration branch April 28, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants