refactor(@schematics/angular): remove third-party typescript copy#33072
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Apr 28, 2026
Merged
Conversation
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the vendored TypeScript dependency from the third_party/typescript directory and replaces it with a direct dependency on the typescript package (version 6.0.3). The changes include updating Bazel build configurations, package.json, and numerous import statements across the schematics package. Feedback was provided regarding the inconsistent import style of the typescript package, suggesting the use of namespace imports (import * as ts) throughout the codebase for better consistency and compatibility.
alan-agius4
force-pushed
the
typescript-third_party_remove
branch
from
82fd1f1 to
f65587e
Compare
clydin
approved these changes
Apr 28, 2026
alan-agius4
added
action: merge
The typescript package is now smaller and the tsserver file no longer bundles typescript but imports it directly, which makes the 3rd party copy redundant.
alan-agius4
force-pushed
the
typescript-third_party_remove
branch
from
f65587e to
ae68b12
Compare
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typescript package is now smaller and the tsserver file no longer bundles typescript but imports it directly, which makes the 3rd party copy redundant.