Skip to content

mypy version bump 1.12.0#39850

Closed
dirrao wants to merge 16 commits intoapache:mainfrom
dirrao:mypy_version_bump
Closed

mypy version bump 1.12.0#39850
dirrao wants to merge 16 commits intoapache:mainfrom
dirrao:mypy_version_bump

Conversation

@dirrao
Copy link
Copy Markdown
Contributor

@dirrao dirrao commented May 26, 2024 •
edited
Loading

mypy version bump 1.12.0

@potiuk potiuk force-pushed the mypy_version_bump branch from 77db1ae to bdef4cd Compare May 26, 2024 21:08
uranusjr
uranusjr requested changes May 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’re hitting python/typeshed#10653 (giving this a red cross to avoid accidental merge)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 12, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jul 12, 2024
@potiuk potiuk removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Jul 12, 2024
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Jul 12, 2024

@dirrao - are you continuing with that :) ?

@dirrao
Copy link
Copy Markdown
Contributor Author

dirrao commented Jul 12, 2024

@dirrao - are you continuing with that :) ?

Yes. We are waiting from the upstream to fix the bug.

@dirrao dirrao changed the title mypy version bump 1.10.0 mypy version bump 1.11.0 Jul 26, 2024
@dirrao
Copy link
Copy Markdown
Contributor Author

dirrao commented Jul 29, 2024

@uranusjr
Are we need to adjust the existing to fix failing checks? Can please check once?

@dirrao dirrao force-pushed the mypy_version_bump branch from afe1cfa to 001441d Compare July 29, 2024 12:01
@dirrao dirrao closed this Jul 29, 2024
@dirrao dirrao reopened this Jul 29, 2024
@dirrao
Copy link
Copy Markdown
Contributor Author

dirrao commented Aug 1, 2024

@uranusjr Can you help me on the failing check?

@dirrao dirrao requested a review from potiuk August 1, 2024 16:32
@dirrao
Copy link
Copy Markdown
Contributor Author

dirrao commented Aug 3, 2024

@potiuk
We are seeing the issue related to typecasting. Do we need this explicit type casting?

airflow/models/dag.py:2760: error: "TaskDecoratorCollection" not callable 
[120](https://github.com/apache/airflow/actions/runs/10155935894/job/28083658202?pr=39850#step:6:121)
[misc]
[121](https://github.com/apache/airflow/actions/runs/10155935894/job/28083658202?pr=39850#step:6:122)
            return cast("TaskDecoratorCollection", functools.partial(task,...
[122](https://github.com/apache/airflow/actions/runs/10155935894/job/28083658202?pr=39850#step:6:123)
                                                   ^
[123](https://github.com/apache/airflow/actions/runs/10155935894/job/28083658202?pr=39850#step:6:124)
Found 1 error in 1 file (checked 1238 source files)
[124](https://github.com/apache/airflow/actions/runs/10155935894/job/28083658202?pr=39850#step:6:125)
Error 1 returned

@uranusjr uranusjr force-pushed the mypy_version_bump branch from c6c9deb to 2623b45 Compare August 5, 2024 07:38
@uranusjr
Copy link
Copy Markdown
Member

uranusjr commented Aug 5, 2024

The errore does not even make sense to me… TaskDecoratorCollection is callable (it has __call__ defined).

@uranusjr uranusjr requested review from XD-DENG, ashb and kaxil as code owners August 5, 2024 07:54
@uranusjr uranusjr force-pushed the mypy_version_bump branch from d1ebe2e to 2623b45 Compare August 5, 2024 08:53
@uranusjr uranusjr removed request for XD-DENG, ashb and kaxil August 5, 2024 08:53
@uranusjr
Add ignore to cast() call
a61a517 
Mypy is weirdly complaining it can't convert a callable to a
TaskDecoratorCollection since the type is not callable. This is wrong
in both ways---TaskDecoratorCollection *is* totally callable, and isn't
cast() supposed to not care anyway?

I don't see there's a viable way to work around this without
significantly impacting typing in other ways, so an ignore marker seems
to be the most reasonable option. The cast() call is kept because Mypy
might fix this ins the future, and when it does, it should report the
marker as redundant and prompt us to remove it.
@uranusjr
Copy link
Copy Markdown
Member

uranusjr commented Aug 6, 2024

The partial issue looks similar to python/mypy#17631

1.11 added special support for partial and that seems to break cases like this. (Not sure what the criteria are exactly.) python/mypy#16939

@uranusjr
Copy link
Copy Markdown
Member

uranusjr commented Aug 6, 2024

Also

/usr/local/lib/python3.8/site-packages/apache_beam/typehints/schemas.py:486: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
If this issue continues with mypy master, please report a bug at [https://github.com/python/mypy/issues](https://github.com/python/mypy/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen)
version: 1.11.0
/usr/local/lib/python3.8/site-packages/apache_beam/typehints/schemas.py:486: : note: please use --show-traceback to print a traceback when reporting a bug

@hauntsaninja
Copy link
Copy Markdown

hauntsaninja commented Oct 17, 2024

Try mypy 1.12 , we fixed at least one issue related to functools.partial that should help

@dirrao dirrao changed the title mypy version bump 1.11.0 mypy version bump 1.12.0 Oct 19, 2024
hauntsaninja
hauntsaninja reviewed Oct 20, 2024
View reviewed changes
Copy link
Copy Markdown

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are a few things from CI that need changes

Comment thread hatch_build.py
@@ -215,7 +215,7 @@
# TODO: upgrade to newer versions of MyPy continuously as they are released
# Make sure to upgrade the mypy version in update-common-sql-api-stubs in .pre-commit-config.yaml
Copy link
Copy Markdown

@hauntsaninja hauntsaninja Oct 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be updated in update-common-sql-api-stubs as per comment?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 5, 2024
@github-actions github-actions Bot closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjr uranusjr uranusjr requested changes

@potiuk potiuk Awaiting requested review from potiuk

+1 more reviewer

@hauntsaninja hauntsaninja hauntsaninja left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:dev-tools stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dirrao @potiuk @uranusjr @hauntsaninja