fix(arrow/cdata): make nativeCRecordBatchReader deterministic#793
Open
zeroshade wants to merge 3 commits intoapache:mainfrom
Open
fix(arrow/cdata): make nativeCRecordBatchReader deterministic#793zeroshade wants to merge 3 commits intoapache:mainfrom
zeroshade wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Instead of relying on a finalizer, make the
nativeCRecordBatchReaderuse atomic Retain and Release to make releasing deterministic.What changes are included in this PR?
Remove the finalizer, call C.ArrowArrayRelease and C.ArrowArrayStreamRelease based on refcount.
Are these changes tested?
Yes, tests cover this already.
Are there any user-facing changes?
Only that retain and release now properly control the determinism of releasing the C memory instead of relying on a finalizer.