Return error from `RleDecoder::reset` rather than panic

[etseidl]

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

• Related to [DISCUSS] Remove panics #7806

During review of #8602 it was noticed that one panic was retained, albeit with a more descriptive message (#8602 (comment)).

Describe the solution you'd like
RleDecoder::reset should return an error rather than panic when not enough data is available.

Describe alternatives you've considered
Keep the assert in place and panic.

Additional context

[etseidl]

My first attempt at fixing this causes some serious performance regressions 😮

details

group                                                                                                      rle_fix                                rle_main
-----                                                                                                      -------                                --------
arrow_array_reader/INT32/Decimal128Array/binary packed skip, mandatory, no NULLs                           1.17     60.8±0.28µs        ? ?/sec    1.00     52.0±0.27µs        ? ?/sec
arrow_array_reader/INT32/Decimal128Array/binary packed skip, optional, half NULLs                          1.05     65.8±0.67µs        ? ?/sec    1.00     62.4±0.33µs        ? ?/sec
arrow_array_reader/INT32/Decimal128Array/binary packed skip, optional, no NULLs                            1.14     61.6±0.36µs        ? ?/sec    1.00     53.9±0.32µs        ? ?/sec
arrow_array_reader/INT32/Decimal128Array/binary packed, mandatory, no NULLs                                1.24     93.5±0.70µs        ? ?/sec    1.00     75.3±0.29µs        ? ?/sec
arrow_array_reader/INT32/Decimal128Array/binary packed, optional, half NULLs                               1.06    113.1±1.40µs        ? ?/sec    1.00    106.9±0.60µs        ? ?/sec
arrow_array_reader/INT32/Decimal128Array/binary packed, optional, no NULLs                                 1.20     95.4±0.49µs        ? ?/sec    1.00     79.5±0.34µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed skip, mandatory, no NULLs                           1.00     56.0±0.29µs        ? ?/sec    1.01     56.5±0.29µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed skip, optional, half NULLs                          1.00     64.4±0.19µs        ? ?/sec    1.06     68.2±0.29µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed skip, optional, no NULLs                            1.00     56.6±0.22µs        ? ?/sec    1.05     59.4±0.70µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed, mandatory, no NULLs                                1.00     82.4±0.43µs        ? ?/sec    1.03     84.7±0.37µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed, optional, half NULLs                               1.00    114.8±0.93µs        ? ?/sec    1.01    116.5±0.58µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed, optional, no NULLs                                 1.00     85.4±0.42µs        ? ?/sec    1.03     88.4±1.53µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed skip, mandatory, no NULLs                                      1.20     49.0±0.30µs        ? ?/sec    1.00     40.9±0.23µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed skip, optional, half NULLs                                     1.06     56.4±0.31µs        ? ?/sec    1.00     52.9±0.23µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed skip, optional, no NULLs                                       1.15     49.6±0.35µs        ? ?/sec    1.00     43.2±0.80µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed, mandatory, no NULLs                                           1.27     71.4±0.78µs        ? ?/sec    1.00     56.2±0.34µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed, optional, half NULLs                                          1.08     95.5±1.25µs        ? ?/sec    1.00     88.0±0.41µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed, optional, no NULLs                                            1.24     73.2±0.42µs        ? ?/sec    1.00     58.9±0.70µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed skip, mandatory, no NULLs                                      1.25     49.1±0.22µs        ? ?/sec    1.00     39.4±0.50µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed skip, optional, half NULLs                                     1.10     55.0±0.30µs        ? ?/sec    1.00     50.1±0.34µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed skip, optional, no NULLs                                       1.21     50.2±0.87µs        ? ?/sec    1.00     41.4±0.24µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed, mandatory, no NULLs                                           1.39     70.6±0.27µs        ? ?/sec    1.00     50.9±0.79µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed, optional, half NULLs                                          1.12     90.6±0.39µs        ? ?/sec    1.00     80.7±0.99µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed, optional, no NULLs                                            1.32     71.7±0.31µs        ? ?/sec    1.00     54.3±0.48µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed skip, mandatory, no NULLs                                      1.00     43.7±0.17µs        ? ?/sec    1.05     45.7±0.28µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed skip, optional, half NULLs                                     1.00     53.6±0.37µs        ? ?/sec    1.07     57.3±0.23µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed skip, optional, no NULLs                                       1.00     45.2±0.18µs        ? ?/sec    1.04     46.8±0.28µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed, mandatory, no NULLs                                           1.00     60.0±0.18µs        ? ?/sec    1.03     61.8±0.28µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed, optional, half NULLs                                          1.00     87.7±0.63µs        ? ?/sec    1.08     94.6±1.09µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed, optional, no NULLs                                            1.00     62.0±0.91µs        ? ?/sec    1.06     65.8±0.25µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed skip, mandatory, no NULLs                                       1.20     49.7±0.24µs        ? ?/sec    1.00     41.3±0.13µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed skip, optional, half NULLs                                      1.06     56.8±0.61µs        ? ?/sec    1.00     53.6±0.23µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed skip, optional, no NULLs                                        1.16     50.2±0.24µs        ? ?/sec    1.00     43.3±0.27µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed, mandatory, no NULLs                                            1.26     72.2±0.51µs        ? ?/sec    1.00     57.3±0.51µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed, optional, half NULLs                                           1.07     95.3±0.50µs        ? ?/sec    1.00     89.2±0.36µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed, optional, no NULLs                                             1.25     75.3±0.84µs        ? ?/sec    1.00     60.2±0.23µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed skip, mandatory, no NULLs                                     1.18     53.2±0.27µs        ? ?/sec    1.00     44.9±0.18µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed skip, optional, half NULLs                                    1.05     58.4±0.67µs        ? ?/sec    1.00     55.4±0.37µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed skip, optional, no NULLs                                      1.13     53.5±0.28µs        ? ?/sec    1.00     47.2±0.88µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed, mandatory, no NULLs                                          1.28     78.4±0.34µs        ? ?/sec    1.00     61.5±0.34µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed, optional, half NULLs                                         1.06     97.6±0.77µs        ? ?/sec    1.00     92.1±0.63µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed, optional, no NULLs                                           1.23     79.2±0.31µs        ? ?/sec    1.00     64.2±0.31µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed skip, mandatory, no NULLs                                     1.22     49.6±0.58µs        ? ?/sec    1.00     40.7±0.16µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed skip, optional, half NULLs                                    1.06     54.8±0.20µs        ? ?/sec    1.00     51.6±0.23µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed skip, optional, no NULLs                                      1.18     50.2±0.32µs        ? ?/sec    1.00     42.5±0.29µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed, mandatory, no NULLs                                          1.34     71.5±0.75µs        ? ?/sec    1.00     53.4±0.26µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed, optional, half NULLs                                         1.07     90.6±0.43µs        ? ?/sec    1.00     84.9±0.52µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed, optional, no NULLs                                           1.29     72.6±0.36µs        ? ?/sec    1.00     56.1±0.35µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed skip, mandatory, no NULLs                                     1.00     43.7±0.21µs        ? ?/sec    1.05     45.7±0.69µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed skip, optional, half NULLs                                    1.00     53.1±0.24µs        ? ?/sec    1.02     54.4±0.31µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed skip, optional, no NULLs                                      1.00     45.3±0.28µs        ? ?/sec    1.03     46.8±0.24µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed, mandatory, no NULLs                                          1.00     60.2±0.20µs        ? ?/sec    1.04     62.6±0.84µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed, optional, half NULLs                                         1.00     87.5±0.36µs        ? ?/sec    1.03     90.0±0.52µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed, optional, no NULLs                                           1.00     62.7±0.26µs        ? ?/sec    1.02     64.1±0.32µs        ? ?/sec
arrow_array_reader/UInt8Array/binary packed skip, mandatory, no NULLs                                      1.18     53.2±0.35µs        ? ?/sec    1.00     45.2±0.49µs        ? ?/sec
arrow_array_reader/UInt8Array/binary packed skip, optional, half NULLs                                     1.04     58.4±0.34µs        ? ?/sec    1.00     56.2±0.31µs        ? ?/sec
arrow_array_reader/UInt8Array/binary packed skip, optional, no NULLs                                       1.16     54.3±0.63µs        ? ?/sec    1.00     47.0±0.25µs        ? ?/sec
aarrow_array_reader/INT32/Decimal128Array/binary packed skip, mandatory, no NULLs                           1.17     60.8±0.28µs        ? ?/sec    1.00     52.0±0.27µs        ? ?/sec
arrow_array_reader/INT32/Decimal128Array/binary packed skip, optional, half NULLs                          1.05     65.8±0.67µs        ? ?/sec    1.00     62.4±0.33µs        ? ?/sec
arrow_array_reader/INT32/Decimal128Array/binary packed skip, optional, no NULLs                            1.14     61.6±0.36µs        ? ?/sec    1.00     53.9±0.32µs        ? ?/sec
arrow_array_reader/INT32/Decimal128Array/binary packed, mandatory, no NULLs                                1.24     93.5±0.70µs        ? ?/sec    1.00     75.3±0.29µs        ? ?/sec
arrow_array_reader/INT32/Decimal128Array/binary packed, optional, half NULLs                               1.06    113.1±1.40µs        ? ?/sec    1.00    106.9±0.60µs        ? ?/sec
arrow_array_reader/INT32/Decimal128Array/binary packed, optional, no NULLs                                 1.20     95.4±0.49µs        ? ?/sec    1.00     79.5±0.34µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed skip, mandatory, no NULLs                           1.00     56.0±0.29µs        ? ?/sec    1.01     56.5±0.29µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed skip, optional, half NULLs                          1.00     64.4±0.19µs        ? ?/sec    1.06     68.2±0.29µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed skip, optional, no NULLs                            1.00     56.6±0.22µs        ? ?/sec    1.05     59.4±0.70µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed, mandatory, no NULLs                                1.00     82.4±0.43µs        ? ?/sec    1.03     84.7±0.37µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed, optional, half NULLs                               1.00    114.8±0.93µs        ? ?/sec    1.01    116.5±0.58µs        ? ?/sec
arrow_array_reader/INT64/Decimal128Array/binary packed, optional, no NULLs                                 1.00     85.4±0.42µs        ? ?/sec    1.03     88.4±1.53µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed skip, mandatory, no NULLs                                      1.20     49.0±0.30µs        ? ?/sec    1.00     40.9±0.23µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed skip, optional, half NULLs                                     1.06     56.4±0.31µs        ? ?/sec    1.00     52.9±0.23µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed skip, optional, no NULLs                                       1.15     49.6±0.35µs        ? ?/sec    1.00     43.2±0.80µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed, mandatory, no NULLs                                           1.27     71.4±0.78µs        ? ?/sec    1.00     56.2±0.34µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed, optional, half NULLs                                          1.08     95.5±1.25µs        ? ?/sec    1.00     88.0±0.41µs        ? ?/sec
arrow_array_reader/Int16Array/binary packed, optional, no NULLs                                            1.24     73.2±0.42µs        ? ?/sec    1.00     58.9±0.70µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed skip, mandatory, no NULLs                                      1.25     49.1±0.22µs        ? ?/sec    1.00     39.4±0.50µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed skip, optional, half NULLs                                     1.10     55.0±0.30µs        ? ?/sec    1.00     50.1±0.34µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed skip, optional, no NULLs                                       1.21     50.2±0.87µs        ? ?/sec    1.00     41.4±0.24µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed, mandatory, no NULLs                                           1.39     70.6±0.27µs        ? ?/sec    1.00     50.9±0.79µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed, optional, half NULLs                                          1.12     90.6±0.39µs        ? ?/sec    1.00     80.7±0.99µs        ? ?/sec
arrow_array_reader/Int32Array/binary packed, optional, no NULLs                                            1.32     71.7±0.31µs        ? ?/sec    1.00     54.3±0.48µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed skip, mandatory, no NULLs                                      1.00     43.7±0.17µs        ? ?/sec    1.05     45.7±0.28µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed skip, optional, half NULLs                                     1.00     53.6±0.37µs        ? ?/sec    1.07     57.3±0.23µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed skip, optional, no NULLs                                       1.00     45.2±0.18µs        ? ?/sec    1.04     46.8±0.28µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed, mandatory, no NULLs                                           1.00     60.0±0.18µs        ? ?/sec    1.03     61.8±0.28µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed, optional, half NULLs                                          1.00     87.7±0.63µs        ? ?/sec    1.08     94.6±1.09µs        ? ?/sec
arrow_array_reader/Int64Array/binary packed, optional, no NULLs                                            1.00     62.0±0.91µs        ? ?/sec    1.06     65.8±0.25µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed skip, mandatory, no NULLs                                       1.20     49.7±0.24µs        ? ?/sec    1.00     41.3±0.13µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed skip, optional, half NULLs                                      1.06     56.8±0.61µs        ? ?/sec    1.00     53.6±0.23µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed skip, optional, no NULLs                                        1.16     50.2±0.24µs        ? ?/sec    1.00     43.3±0.27µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed, mandatory, no NULLs                                            1.26     72.2±0.51µs        ? ?/sec    1.00     57.3±0.51µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed, optional, half NULLs                                           1.07     95.3±0.50µs        ? ?/sec    1.00     89.2±0.36µs        ? ?/sec
arrow_array_reader/Int8Array/binary packed, optional, no NULLs                                             1.25     75.3±0.84µs        ? ?/sec    1.00     60.2±0.23µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed skip, mandatory, no NULLs                                     1.18     53.2±0.27µs        ? ?/sec    1.00     44.9±0.18µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed skip, optional, half NULLs                                    1.05     58.4±0.67µs        ? ?/sec    1.00     55.4±0.37µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed skip, optional, no NULLs                                      1.13     53.5±0.28µs        ? ?/sec    1.00     47.2±0.88µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed, mandatory, no NULLs                                          1.28     78.4±0.34µs        ? ?/sec    1.00     61.5±0.34µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed, optional, half NULLs                                         1.06     97.6±0.77µs        ? ?/sec    1.00     92.1±0.63µs        ? ?/sec
arrow_array_reader/UInt16Array/binary packed, optional, no NULLs                                           1.23     79.2±0.31µs        ? ?/sec    1.00     64.2±0.31µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed skip, mandatory, no NULLs                                     1.22     49.6±0.58µs        ? ?/sec    1.00     40.7±0.16µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed skip, optional, half NULLs                                    1.06     54.8±0.20µs        ? ?/sec    1.00     51.6±0.23µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed skip, optional, no NULLs                                      1.18     50.2±0.32µs        ? ?/sec    1.00     42.5±0.29µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed, mandatory, no NULLs                                          1.34     71.5±0.75µs        ? ?/sec    1.00     53.4±0.26µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed, optional, half NULLs                                         1.07     90.6±0.43µs        ? ?/sec    1.00     84.9±0.52µs        ? ?/sec
arrow_array_reader/UInt32Array/binary packed, optional, no NULLs                                           1.29     72.6±0.36µs        ? ?/sec    1.00     56.1±0.35µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed skip, mandatory, no NULLs                                     1.00     43.7±0.21µs        ? ?/sec    1.05     45.7±0.69µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed skip, optional, half NULLs                                    1.00     53.1±0.24µs        ? ?/sec    1.02     54.4±0.31µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed skip, optional, no NULLs                                      1.00     45.3±0.28µs        ? ?/sec    1.03     46.8±0.24µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed, mandatory, no NULLs                                          1.00     60.2±0.20µs        ? ?/sec    1.04     62.6±0.84µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed, optional, half NULLs                                         1.00     87.5±0.36µs        ? ?/sec    1.03     90.0±0.52µs        ? ?/sec
arrow_array_reader/UInt64Array/binary packed, optional, no NULLs                                           1.00     62.7±0.26µs        ? ?/sec    1.02     64.1±0.32µs        ? ?/sec
arrow_array_reader/UInt8Array/binary packed skip, mandatory, no NULLs                                      1.18     53.2±0.35µs        ? ?/sec    1.00     45.2±0.49µs        ? ?/sec
arrow_array_reader/UInt8Array/binary packed skip, optional, half NULLs                                     1.04     58.4±0.34µs        ? ?/sec    1.00     56.2±0.31µs        ? ?/sec
arrow_array_reader/UInt8Array/binary packed skip, optional, no NULLs                                       1.16     54.3±0.63µs        ? ?/sec    1.00     47.0±0.25µs        ? ?/sec
arrow_array_reader/UInt8Array/binary packed, mandatory, no NULLs                                           1.28     78.1±0.36µs        ? ?/sec    1.00     60.8±0.61µs        ? ?/sec
arrow_array_reader/UInt8Array/binary packed, optional, half NULLs                                          1.04     97.7±0.57µs        ? ?/sec    1.00     94.1±0.43µs        ? ?/sec
arrow_array_reader/UInt8Array/binary packed, optional, no NULLs                                            1.24     79.6±0.45µs        ? ?/sec    1.00     64.2±0.39µs        ? ?/sec
rrow_array_reader/UInt8Array/binary packed, mandatory, no NULLs                                           1.28     78.1±0.36µs        ? ?/sec    1.00     60.8±0.61µs        ? ?/sec
arrow_array_reader/UInt8Array/binary packed, optional, half NULLs                                          1.04     97.7±0.57µs        ? ?/sec    1.00     94.1±0.43µs        ? ?/sec
arrow_array_reader/UInt8Array/binary packed, optional, no NULLs                                            1.24     79.6±0.45µs        ? ?/sec    1.00     64.2±0.39µs        ? ?/sec

[alamb]

label_issue.py automatically added labels {'parquet'} from #8602