[avro] Fix Avro decoder bitmap corruption when nullable field decoding fails#8213
Merged
alamb merged 1 commit intoapache:mainfrom Aug 24, 2025
Merged
Conversation
github-actions
Bot
added
arrow
Contributor
|
@jecsand838 could you please also review this PR? |
Contributor
|
@yongkyunlee This was a solid catch. Thank you so much for discovering it and getting this PR up. LGTM |
jecsand838
approved these changes
Aug 24, 2025
yongkyunlee
changed the title
alamb
approved these changes
Aug 24, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Tank you @yongkyunlee and @jecsand838
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
In the original code, the bitmap was modified before decoding. Even if decoding fails, the null buffer was modified, leading to bitmap corruption, eventually causing flush to fail.
What changes are included in this PR?
This PR fixes the bug where the bitmap was modified before decoding. If there is decoding failure, the bitmap should not be modified but the decode method should be exited gracefully without any side effect.
Are these changes tested?
Are there any user-facing changes?
No.