perf: Avoid ArrayData allocation in PrimitiveArray::reinterpret_cast#9129
Merged
alamb merged 3 commits intoapache:mainfrom Jan 11, 2026
Merged
Conversation
alamb
commented
Jan 9, 2026
| // SAFETY: | ||
| // Native type is the same | ||
| PrimitiveArray::from(unsafe { d.build_unchecked() }) | ||
| PrimitiveArray::new(self.values.clone(), self.nulls.clone()) |
Contributor
Author
There was a problem hiding this comment.
Bonus points that it removes some unsafe
Jefffrey
approved these changes
Jan 10, 2026
Contributor
Author
Dandandan
pushed a commit
to Dandandan/arrow-rs
that referenced
this pull request
Jan 15, 2026
…pache#9129) # Which issue does this PR close? - part of apache#9128 # Rationale for this change While studying / profiling the Parquet reader I have noticed several places where unecessary allocations are happening # What changes are included in this PR? Avoid ArrayData allocation in `PrimitiveArray::reinterpret_cast` # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> --------- Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While studying / profiling the Parquet reader I have noticed several places where unecessary allocations are happening
What changes are included in this PR?
Avoid ArrayData allocation in
PrimitiveArray::reinterpret_castAre these changes tested?
Are there any user-facing changes?