Remove support for List types in bit_length kernel#9350
Merged
alamb merged 1 commit intoapache:mainfrom Feb 5, 2026
Merged
Conversation
Jefffrey
approved these changes
Feb 4, 2026
Contributor
|
Not sure if this is significant enough to be considered a breaking change; I'll mark it so to be safe 🤔 |
Contributor
|
Thanks @codephage2020 and @Jefffrey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Listtypes inbit_lengthkernel #9349 .Rationale for this change
bit_length for List/LargeList multiplies element count by 8, which is semantically wrong since elements can be arbitrary types.
What changes are included in this PR?
remove the existing List/LargeList support for bit_length
Are these changes tested?
YES
Are there any user-facing changes?
NO