Add list-like types support to VariantArray::try_new#9457
Add list-like types support to VariantArray::try_new#9457scovich merged 2 commits intoapache:mainfrom
Conversation
scovich
left a comment
There was a problem hiding this comment.
Main question in my mind: Is this like binary, where we need to force everything to a preferred list type that downstream variant code requires? Or just a few missing match arms? I think it's the latter, but I don't see any tests in this PR that give evidence in either direction?
It is the latter. I didn't add any tests because I didn't see any for other types, including originally supported List. Other types seem to be covered by existing integration tests suite, but it shouldn't cover other List-like types cases. I'll add some unit tests. |
|
@scovich I added the unit tests |
Which issue does this PR close?
LargeList/ListView/LargeListViewforVariantArray::try_new#9455.Rationale for this change
check issue
What changes are included in this PR?
Added list types support to
VariantArraydata type checkingAre these changes tested?
Are there any user-facing changes?