Skip to content

Add list-like types support to VariantArray::try_new#9457

Merged
scovich merged 2 commits intoapache:mainfrom
sdf-jkl:variant-list-arrays-support
Feb 25, 2026
Merged

Add list-like types support to VariantArray::try_new#9457
scovich merged 2 commits intoapache:mainfrom
sdf-jkl:variant-list-arrays-support

Conversation

@sdf-jkl
Copy link
Copy Markdown
Contributor

@sdf-jkl sdf-jkl commented Feb 21, 2026

Which issue does this PR close?

Rationale for this change

check issue

What changes are included in this PR?

Added list types support to VariantArray data type checking

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added the parquet-variant parquet-variant* crates label Feb 21, 2026
@sdf-jkl
Copy link
Copy Markdown
Contributor Author

sdf-jkl commented Feb 21, 2026

@alamb @scovich. Other infrastructure for these types seems to be already in place.

Copy link
Copy Markdown
Contributor

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main question in my mind: Is this like binary, where we need to force everything to a preferred list type that downstream variant code requires? Or just a few missing match arms? I think it's the latter, but I don't see any tests in this PR that give evidence in either direction?

@sdf-jkl
Copy link
Copy Markdown
Contributor Author

sdf-jkl commented Feb 23, 2026

Main question in my mind: Is this like binary, where we need to force everything to a preferred list type that downstream variant code requires? Or just a few missing match arms? I think it's the latter, but I don't see any tests in this PR that give evidence in either direction?

It is the latter. I didn't add any tests because I didn't see any for other types, including originally supported List.

Other types seem to be covered by existing integration tests suite, but it shouldn't cover other List-like types cases.

I'll add some unit tests.

@sdf-jkl
Copy link
Copy Markdown
Contributor Author

sdf-jkl commented Feb 25, 2026

@scovich I added the unit tests

@sdf-jkl sdf-jkl requested a review from scovich February 25, 2026 16:40
Copy link
Copy Markdown
Contributor

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@scovich scovich merged commit 2bf6909 into apache:main Feb 25, 2026
17 checks passed
@sdf-jkl sdf-jkl deleted the variant-list-arrays-support branch February 25, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet-variant parquet-variant* crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable LargeList / ListView / LargeListView for VariantArray::try_new

3 participants