Skip to content

GH-47092: [Release] Fix errors in APT/Yum previous version verification #47093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Jul 14, 2025
Merged

GH-47092: [Release] Fix errors in APT/Yum previous version verification #47093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 46 additions & 6 deletions .github/workflows/verify_rc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,37 @@ jobs:
VERSION: ${{ needs.target.outputs.version }}
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0
- name: Run
run: |
dev/release/verify-release-candidate.sh ${VERSION} ${RC}
- name: Verify the previous version
# TODO: We may re-enable this in the future.
# There are some problems for now:
# * We need to specify the previous versions for all
# dependencies explicitly. For example, "apt install
# libarrow-glib-dev=20.0.0-1" doesn't work. We need "apt
# install libarrow-glib-dev=20.0.0-1
# libarrow-acero-dev=20.0.0-1 libparquet-dev=20.0.0-1
# gir1.2-arrow-1.0=20.0.0-1 libparquet-dev=20.0.0-1
# libarrow-dev=20.0.0-1"
Copy link
Copy Markdown
Member Author

@kou kou Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#47097

continue-on-error: true
run: |
major_version=${VERSION%%.*}
previous_major_version$((major_version - 1))
previous_major_version=$((major_version - 1))
previous_version=${previous_major_version}.0.0
rc=0 # This number isn't used for APT verification
dev/release/verify-release-candidate.sh ${previous_version} ${rc}
previous_tag=apache-arrow-${previous_version}
git checkout ${previous_tag}
# This is workaround. dev/release/verify-release-candidate.sh
# in < 21.0.0 doesn't accept 20.0.0 as the VERSION argument.
# We can remove this workaround after 21.0.0 release.
sed \
-i \
-e 's/^\(ensure_source_directory\)$/# \1/' \
-e 's/^\(test_source_distribution\)$/# \1/' \
dev/release/verify-release-candidate.sh
dev/release/verify-release-candidate.sh ${previous_version}

binary:
name: Binary
Expand Down Expand Up @@ -234,13 +255,32 @@ jobs:
VERSION: ${{ needs.target.outputs.version }}
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0
- name: Run
run: |
dev/release/verify-release-candidate.sh ${VERSION} ${RC}
- name: Verify the previous version
# TODO: We may re-enable this in the future.
# There are some problems for now:
# * x86_64: libLLVM.so.18.1 needed by gandiva2000-libs on AlmaLinux 9
Copy link
Copy Markdown
Member Author

@kou kou Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not our problem. AlmaLinux 9 upgraded its LLVM version to 19 and stopped providing 18.

# * arm64: libarrow.so.2000.0.0: refers the
# "std::condition_variable::wait(std::unique_lock<std::mutex>&)@GLIBCXX_3.4.30"
# (not "...@@GLIBCXX_3.4.30" nor "...@GLIBCXX_3.4.11") symbol on
# AmazonLinux 2023.
Copy link
Copy Markdown
Member Author

@kou kou Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is not our problem. I think that Amazon Linux 2023 changed g++ or g++ related packages. (FYI: libarrow.so.2100.0.0 refers ...@GLIBCXX_3.4.11 but we didn't change g++.)

continue-on-error: true
run: |
major_version=${VERSION%%.*}
previous_major_version$((major_version - 1))
previous_major_version=$((major_version - 1))
previous_version=${previous_major_version}.0.0
rc=0 # This number isn't used for Yum verification
dev/release/verify-release-candidate.sh ${previous_version} ${rc}
previous_tag=apache-arrow-${previous_version}
git checkout ${previous_tag}
# This is workaround. dev/release/verify-release-candidate.sh
# in < 21.0.0 doesn't accept 20.0.0 as the VERSION argument.
# We can remove this workaround after 21.0.0 release.
sed \
-i \
-e 's/^\(ensure_source_directory\)$/# \1/' \
-e 's/^\(test_source_distribution\)$/# \1/' \
dev/release/verify-release-candidate.sh
dev/release/verify-release-candidate.sh ${previous_version}
12 changes: 10 additions & 2 deletions dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,11 +776,19 @@ ensure_source_directory() {
elif [ "${SOURCE_KIND}" = "git" ]; then
# Remote arrow repository, testing repositories must be cloned
: ${SOURCE_REPOSITORY:="https://github.com/apache/arrow"}
echo "Verifying Arrow repository ${SOURCE_REPOSITORY} with revision checkout ${VERSION}"
case "${VERSION}" in
*.*.*)
revision="apache-arrow-${VERSION}"
;;
*)
revision="${VERSION}"
;;
esac
echo "Verifying Arrow repository ${SOURCE_REPOSITORY} with revision checkout ${revision}"
export ARROW_SOURCE_DIR="${ARROW_TMPDIR}/arrow"
if [ ! -d "${ARROW_SOURCE_DIR}" ]; then
git clone --recurse-submodules $SOURCE_REPOSITORY $ARROW_SOURCE_DIR
git -C $ARROW_SOURCE_DIR checkout $VERSION
git -C $ARROW_SOURCE_DIR checkout "${revision}"
fi
else
# Release tarball, testing repositories must be cloned separately
Expand Down
Loading