GH-19667: [C++][Gandiva] Replace RegexUtil out references with pointer out args#49879
Open
Reranko05 wants to merge 1 commit intoapache:mainfrom
Open
GH-19667: [C++][Gandiva] Replace RegexUtil out references with pointer out args#49879Reranko05 wants to merge 1 commit intoapache:mainfrom
Reranko05 wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
github-actions
Bot
added
Component: C++
Component: Gandiva
awaiting review
Contributor
Author
|
@kou opened this PR for discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Replaced mutable reference out arguments with pointer out arguments to align with Gandiva style guidance. This PR addresses a scoped
RegexUtilslice of that issue.What changes are included in this PR?
RegexUtil::SqlLikePatternToPcremutable reference out arguments with pointer out arguments.regex_functions_holder.cc.regex_functions_holder_test.cc.Are these changes tested?
ninja gandivaAre there any user-facing changes?
No