Skip to content

Fix flaky FileIOTest.testMatchWatchForNewFiles test under CI filesystems#38047

Draft
bvolpato wants to merge 1 commit intoapache:masterfrom
bvolpato:bvolpato/fix-fileio-flaky-test
Draft

Fix flaky FileIOTest.testMatchWatchForNewFiles test under CI filesystems#38047
bvolpato wants to merge 1 commit intoapache:masterfrom
bvolpato:bvolpato/fix-fileio-flaky-test

Conversation

@bvolpato
Copy link
Copy Markdown
Contributor

@bvolpato bvolpato commented Apr 2, 2026

Please add a meaningful description for your change here

addresses #19480

The FileIOTest.testMatchWatchForNewFiles test occasionally flakes in the CI environment because the updOptions configuration in CopyFilesFn does not preserve file attributes when overwriting existing files. In some CI filesystems, this causes the copied file to register a lastModifiedMillis timestamp of 0. Thus, when ExtractFilenameAndLastUpdateFn parses this file, it throws a RuntimeException at FileIO.java:800, failing the pipeline run.

This PR adds StandardCopyOption.COPY_ATTRIBUTES to preserve the file's original timestamps, avoiding the exception.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a flaky test in FileIOTest by ensuring that file attributes are correctly maintained when files are replaced. By preserving original timestamps and increasing the wait time for file operations, the test becomes more resilient to the timing and filesystem constraints often encountered in CI environments.

Highlights

  • File Attribute Preservation: Updated the file copy options to include StandardCopyOption.COPY_ATTRIBUTES, ensuring file timestamps are preserved during overwrites to prevent failures in CI environments.
  • Test Stability: Increased the Thread.sleep duration from 100ms to 500ms in the test logic to provide more headroom for high-load CI filesystems.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the java label Apr 2, 2026
@bvolpato bvolpato marked this pull request as draft April 2, 2026 14:49
@bvolpato bvolpato force-pushed the bvolpato/fix-fileio-flaky-test branch from e521a7b to 5b40803 Compare April 2, 2026 15:38
addresses apache#19480

The `FileIOTest.testMatchWatchForNewFiles` test occasionally flakes in the CI environment because the `updOptions` configuration in `CopyFilesFn` does not preserve file attributes when overwriting existing files. In some CI filesystems, this causes the copied file to register a `lastModifiedMillis` timestamp of `0`. Thus, when `ExtractFilenameAndLastUpdateFn` parses this file, it throws a `RuntimeException` at `FileIO.java:800`, failing the pipeline run.

This PR adds `StandardCopyOption.COPY_ATTRIBUTES` to preserve the file's original timestamps, avoiding the exception.
@bvolpato bvolpato force-pushed the bvolpato/fix-fileio-flaky-test branch from 5b40803 to 4350fb8 Compare April 2, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant