You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Overall LGTM, but I also have a couple of questions regarding the expiration strategy when multiple apps exceed the app-level quota:
Priority-based expiration: When a user exceeds their overall quota and multiple apps also exceed the app-level threshold, could we prioritize which apps to expire based on app priority (or consumption)? This would allow more important apps to continue running while less critical ones are throttled first.
Incremental expiration: After expiring a single app, if the remaining apps no longer exceed the quota, is it possible to avoid expiring them? This would minimize the impact to the user's workload by only expiring the minimum number of apps necessary to bring usage back under the quota limit.
Overall LGTM, but I also have a couple of questions regarding the expiration strategy when multiple apps exceed the app-level quota:
Priority-based expiration: When a user exceeds their overall quota and multiple apps also exceed the app-level threshold, could we prioritize which apps to expire based on app priority (or consumption)? This would allow more important apps to continue running while less critical ones are throttled first.
Incremental expiration: After expiring a single app, if the remaining apps no longer exceed the quota, is it possible to avoid expiring them? This would minimize the impact to the user's workload by only expiring the minimum number of apps necessary to bring usage back under the quota limit.
by claude
Subsequent PRs will be prioritized based on priority and consumption.
Incremental expiration was already supported before this PR. This PR aims to introduce a new app threshold based on fairness considerations. We don't want quotas to be consumed by a few apps. When the user/tenant/cluster quota is exceeded, apps exceeding the app threshold will be killed first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reopen from #3336, QuotaManager supports app threshold.
Why are the changes needed?
For CIP-19, prioritize cleaning up abnormally large shuffle apps, then sort by app priority and consumption.
Does this PR resolve a correctness bug?
No.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
UTs.