Incorrect memory usage for VMware instances in the metrics

[rajujith]

ISSUE TYPE

• Bug Report

COMPONENT NAME

API,UI

CLOUDSTACK VERSION

4.16.1.1, 4.19.1 

CONFIGURATION

Vmware vSphere

SUMMARY

The 'memoryintfreekbs' returned by CloudStack API listVirtualMachinesMetrics is not the 'Free' memory instead it is the memory used in the vSphere. This value is taken from MOB property of VM 'summary.quickStats.guestMemoryUsage' and used as is.
final String guestMemUseStr = "summary.quickStats.guestMemoryUsage";

cloudstack/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

Line 6513 in 546ef31

final String guestMemUseStr = "summary.quickStats.guestMemoryUsage";

This results in the Memory used being displayed as Memory Free.

STEPS TO REPRODUCE

Compare the Memory Free/Used in VM metrics in CloudStack with vCenter/MOB. 

EXPECTED RESULTS

Instance metrics should list accurate memory usage. 

ACTUAL RESULTS

Instance metrics list incorrect memory usage. 

[DaanHoogland]

fixed in #6414