Existing Template Settings are deleted when an Update Template api is executed

[kiranchavala]

problem

Existing Template Settings are deleted when an Update Template api is executed

versions

ACS 4.22

The steps to reproduce the bug

1. Register a template in Cloudstack

2. Navigate to Images > Tempaltes> Settings

Make sure only the template has the rootDiskController setting to osdefault

3. Verify the database

mysql> select * from vm_template_details where template_id=215;
+----+-------------+--------------------+-----------+---------+
| id | template_id | name               | value     | display |
+----+-------------+--------------------+-----------+---------+
| 41 |         215 | rootDiskController | osdefault |       1 |
+----+-------------+--------------------+-----------+---------+
1 row in set (0.00 sec)

4. Add a uefi setting

5. Verify the database

mysql> select * from vm_template_details where template_id=215;
+----+-------------+--------------------+-----------+---------+
| id | template_id | name               | value     | display |
+----+-------------+--------------------+-----------+---------+
| 42 |         215 | UEFI               | SECURE    |       1 |
| 43 |         215 | rootDiskController | osdefault |       1 |
+----+-------------+--------------------+-----------+---------+
2 rows in set (0.00 sec)

6. Now Edit/ update the template

Change the root disk controller to scsi

7. Check the Database and the UI , the uefi setting is lost

mysql> select * from vm_template_details where template_id=215;
+----+-------------+--------------------+-------+---------+
| id | template_id | name               | value | display |
+----+-------------+--------------------+-------+---------+
| 44 |         215 | rootDiskController | scsi  |       1 |
+----+-------------+--------------------+-------+---------+
1 row in set (0.00 sec)

What to do about it?

The existing template settings should not be deleted when the edit/update template is peformed

[DaanHoogland]

@kiranchavala , did you verify this on earlier versions?

[slavkap]

Hi @kiranchavala, @DaanHoogland, there is the same problem with update virtual machine details with cloudmonkey

(admin) 🐱 > list virtualmachines id=fd953c75-34ac-4324-ba25-175e7fc5dd72 filter=details
{
  "count": 1,
  "virtualmachine": [
    {
      "details": {
        "rootDiskController": "osdefault"
      }
    }
  ]
}
(admin) 🐱 > update virtualmachine id=fd953c75-34ac-4324-ba25-175e7fc5dd72 details[0].UEFI=secure filter=details
{
  "virtualmachine": {
    "details": {
      "UEFI": "secure"
    }
  }
}

I think this affects older versions but I don't have an env. to test it

[kiranchavala]

Thanks @slavkap the issue exists even for the virtual machines

@DaanHoogland I have checked on older versions 4.19, 4.20 and issue exists for virtualmachines and templates

[sureshanaparti]

Fixed in #12559