Skip to content

Vmware fix test errors#10162

Open
iishitahere wants to merge 4 commits intoapache:4.22from
iishitahere:vmware-fix-test-errors
Open

Vmware fix test errors#10162
iishitahere wants to merge 4 commits intoapache:4.22from
iishitahere:vmware-fix-test-errors

Conversation

@iishitahere
Copy link
Copy Markdown

This PR implements enhancements related to traffic shaping and VMware network configurations:

NetUtilsTest: Improved handling of default NIC IPs to ensure compatibility with both IPv4 and IPv6 formats for traffic shaping configurations.
ScriptTest: Updated command execution handling to ensure better compatibility with VMware's network setup, improving timeout management and process error handling.
ProcessTest: Addressed potential race conditions in process execution, enhancing stability during network traffic shaping tests on VMware environments.

@sureshanaparti
Copy link
Copy Markdown
Contributor

@blueorangutan package

@sureshanaparti sureshanaparti added this to the 4.21.0 milestone Jun 5, 2025
@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13618

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (546ef31) to head (6d327d5).
⚠️ Report is 888 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main   #10162       +/-   ##
=============================================
- Coverage     15.80%        0   -15.81%     
=============================================
  Files          5627        0     -5627     
  Lines        492363        0   -492363     
  Branches      59696        0    -59696     
=============================================
- Hits          77828        0    -77828     
+ Misses       406012        0   -406012     
+ Partials       8523        0     -8523     
Flag Coverage Δ
uitests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13669

ProcessResult result = RUNNER.executeCommands(Arrays.asList("sleep", "0"));
// Replace "sleep" with the cross-platform "timeout" command
ProcessResult result = RUNNER.executeCommands(Arrays.asList("timeout", "/t", "1"));
Assert.assertEquals(result.getReturnCode(), 0);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iishitahere , this test fails at this assert.

@rajujith
Copy link
Copy Markdown
Contributor

@iishitahere Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?

@DaanHoogland DaanHoogland changed the base branch from main to 4.22 January 13, 2026 12:38
@sureshanaparti
Copy link
Copy Markdown
Contributor

Hi @iishitahere, Can you check the build error, and outstanding comments.

@iishitahere
Copy link
Copy Markdown
Author

Hi @sureshanaparti,
Thanks for the reminder.
I’ve reviewed the build failures and the outstanding comment from @DaanHoogland regarding the ProcessTest assertion. The issue appears to be due to OS-specific command usage (timeout /t) which fails in Linux-based CI environments.
I will update the test to remove OS dependency and ensure cross-platform compatibility, and push an updated commit shortly.
Please let me know if there are any additional concerns I should address.

@sureshanaparti
Copy link
Copy Markdown
Contributor

Hi @iishitahere Can you address the outstanding comments and build error. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants