Skip to content

Fix config drive iso path on Vmware#2769

Merged
yadvr merged 2 commits intoapache:4.11from
nuagenetworks:bugfix/2759
Jul 31, 2018
Merged

Fix config drive iso path on Vmware#2769
yadvr merged 2 commits intoapache:4.11from
nuagenetworks:bugfix/2759

Conversation

@krissterckx
Copy link
Copy Markdown
Contributor

@krissterckx krissterckx commented Jul 25, 2018

Description

Fixing capitalized 'ConfigDrive' iso path to lowercase 'configdrive'

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Fixes: #2759

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@krissterckx
Fix config drive iso path on Vmware
02bca88 
Fix capitalized 'ConfigDrive' to lowercase 'configdrive'

Fixes: apache#2759
@borisstoyanov
Copy link
Copy Markdown
Contributor

borisstoyanov commented Jul 25, 2018

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 25, 2018

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 25, 2018

Packaging result: ✖centos6 ✖centos7 ✔debian. JID-2206

@yadvr yadvr added this to the 4.11.2.0 milestone Jul 25, 2018
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jul 26, 2018

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 26, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 26, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2208

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jul 26, 2018

@blueorangutan test centos7 vmware-65

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 26, 2018

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests

@wido
Copy link
Copy Markdown
Contributor

wido commented Jul 26, 2018

In which part of the code is the lowercase 'configdrive' set?

sateesh-chodapuneedi
sateesh-chodapuneedi reviewed Jul 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@sateesh-chodapuneedi sateesh-chodapuneedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @krissterckx
Can the string be defined as constant instead of hard-coding it?
Is this check done any where else in the code base?

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 26, 2018

Trillian test result (tid-2889)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36675 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2769-t2889-vmware-65.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_05_rvpc_multi_tiers Failure 510.15 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 547.57 test_vpc_redundant.py

borisstoyanov
borisstoyanov approved these changes Jul 27, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smeetsr
smeetsr approved these changes Jul 28, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@smeetsr smeetsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as well using VmwareESXI6.5 Hosts

@fmaximus
Copy link
Copy Markdown
Contributor

fmaximus commented Jul 30, 2018

@sateesh-chodapuneedi I agree, especially since there already is a constant defined: ConfigDrive.CONFIGDRIVEDIR

@krissterckx
Copy link
Copy Markdown
Contributor Author

krissterckx commented Jul 31, 2018

@rhtyd good for merge, correct?

@yadvr yadvr merged commit 71bbbb7 into apache:4.11 Jul 31, 2018
@snyk-bot snyk-bot mentioned this pull request Jul 13, 2021
Open
Tonitzpp pushed a commit to scclouds/cloudstack that referenced this pull request Dec 18, 2025
@gp-santos
Merge branch 'backport-vitor' into '4.20.0.0-scclouds'
71af33e 
Correção na cópia de _snapshots_ incrementais entre zonas

Closes apache#2769

See merge request scclouds/scclouds!1267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sateesh-chodapuneedi sateesh-chodapuneedi sateesh-chodapuneedi left review comments

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@rafaelweingartner rafaelweingartner Awaiting requested review from rafaelweingartner

+1 more reviewer

@smeetsr smeetsr smeetsr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.11.2.0

Development

Successfully merging this pull request may close these issues.

9 participants

@krissterckx @borisstoyanov @blueorangutan @yadvr @wido @fmaximus @sateesh-chodapuneedi @DaanHoogland @smeetsr