Skip to content

increase width of field in UI#3703

Merged
yadvr merged 1 commit intoapache:masterfrom
shapeblue:ui-span-width-pa
Nov 26, 2019
Merged

increase width of field in UI#3703
yadvr merged 1 commit intoapache:masterfrom
shapeblue:ui-span-width-pa

Conversation

@PaulAngus
Copy link
Copy Markdown
Member

@PaulAngus PaulAngus commented Nov 21, 2019

Description

this fixes: #3697

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • [ * ] Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

This fixes times when long names are truncated, despite there being much more space available

image

image

How Has This Been Tested?

@PaulAngus
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-375

@yadvr yadvr added this to the 4.14.0.0 milestone Nov 21, 2019
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot lgtm

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 21, 2019

Did a quick test on Primate, very-very long names are handled like this:
Screenshot from 2019-11-22 01-07-30
Screenshot from 2019-11-22 01-07-38

@PaulAngus
Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@PaulAngus a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@PaulAngus
Copy link
Copy Markdown
Member Author

after PR fields now look as follows:

image

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-507)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27154 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3703-t507-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Copy Markdown
Contributor

lgtm,
@rhtyd did you test that in all kinds of browsers in primate? just as a heads up, we saw differences between browsers and even between the same browser on different platforms.

@DaanHoogland
Copy link
Copy Markdown
Contributor

@PaulAngus I don't think oran utang will tell us anything on this one. Do you think we need to do a full walk through of the UI? Only details tables are affected so I think we are fine with your proof above.

@yadvr yadvr changed the title WIP increase width of field in UI increase width of field in UI Nov 26, 2019
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 26, 2019

LGTM, we can merge based on the screenshot proofs

@yadvr yadvr merged commit a65a931 into apache:master Nov 26, 2019
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Name and Description fields of Projects in UI is too short

5 participants